Fix for Moment deprecation warning #1371
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moment deprecated calling moment() without formatting information, and the defaultDate setup was calling getMoment() without ever having fired initFormatting(). This threw an ugly deprecation warning in the console from Moment.
|
Can we get this merged? |
|
Any update about this issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moment deprecated calling
moment()without formatting information, and the defaultDate setup was callinggetMoment()without ever having firedinitFormatting(). This threw an ugly deprecation warning in the console from Moment.An example can be seen at this jsFiddle: https://jsfiddle.net/gcnzb1vj/
This fix will trigger
initFormatting()before trying to callgetMoment()as part of the default date setup.