Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default popup behavior functions #2643

Merged
merged 13 commits into from
Sep 15, 2022
Merged

Default popup behavior functions #2643

merged 13 commits into from
Sep 15, 2022

Conversation

oschleic
Copy link
Contributor

PRs relating to the v4 will be closed and locked.

  • Please check if the PR fulfills these requirements
  • The PR is against the development branch
  • Tests for the changes have been added (for bug fixes / features)
    Not sure where to add tests
  • Docs have been added / updated (for bug fixes / features)
    Not sure where to add docs (plugins?)
  • Does NOT modify files under the "dist" folder.
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...). If this is a fix, please tag a bug.

Default behavior for popups, allows for behavior to be overwritten with createPopup(element: HTMLElement, widget: HTMLElement, options: any): any and updatePopup(): void

  • What is the current behavior? (You can also link to an open issue here)

#2640

  • What is the new behavior (if this is a feature change)?

Allows for custom popup behavior to be implemented in plugins.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No breaking change.

  • Other information:

Looking for some initial thoughts on this.

@oschleic oschleic changed the base branch from master to development September 1, 2022 22:49
@oschleic
Copy link
Contributor Author

oschleic commented Sep 8, 2022

@Eonasdan Curious on your thoughts here, don't want to go too far in the wrong direction

@Eonasdan
Copy link
Owner

I was on vacation last. Any down side to doing it this way?

@oschleic
Copy link
Contributor Author

Ah, no worries. There are no large drawbacks that I know of. It may be useful to throw an error if the import does not resolve, also need to change the type of the options parameter. Also should change the optional popper dependency to allow 2.X versions, or at least bump the version to latest.

If it works for you I'd be happy to fix this up and add documentation for it.

@Eonasdan
Copy link
Owner

That sounds good. If it needs to change later we can do that. Thanks again for this.

@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@oschleic
Copy link
Contributor Author

Should be good to go now

@Eonasdan Eonasdan merged commit a0688e4 into Eonasdan:development Sep 15, 2022
@Eonasdan
Copy link
Owner

Thanks again for this

Eonasdan added a commit that referenced this pull request Sep 22, 2022
@Eonasdan @m-gallesio
@oschleic @omerfarukz
Master dev (#2659)
7fbf2a1 
* provide repl example

* remove debug statement

* fix version number in docs

* fix npm issues

* Fixes to fr, fi and it locales (#2650)

* Development (#2637)

* provide repl example

* remove debug statement

* fix version number in docs

* fix npm issues

* Locales:
- fixed exported names of "fr" and "fi"
- fixed decade casing in "it"
- uniformed quotes to single in "fr" and "it"

Co-authored-by: Eonasdan <me@eonasdan.com>

* Default popup behavior functions (#2643)

* FloatingUIDOM conversion

* Revert "FloatingUIDOM conversion"

This reverts commit fd1dd24.

* Move to functions

* Remove dep

* Post Build

* Optional import

* Revert version change

* Revert dist changes

* Cleanup and documentation for floatingui

* Cleanup

* Fix mistake

* Final cleanup

Co-authored-by: Owen Schleicher <owen@swarmbox.com>

* Create tr.ts (#2654)

* Feat/fix ts import (#2653)

* fix ts import
added customDateFormat.html

* updated version

* updated version/change log

* make sonar happy

* template updates

* Revert "template updates"

This reverts commit 4e87b86.

* template updates

* template updates

* update packages

Co-authored-by: m-gallesio <46478501+m-gallesio@users.noreply.github.com>
Co-authored-by: oschleic <80231626+oschleic@users.noreply.github.com>
Co-authored-by: Owen Schleicher <owen@swarmbox.com>
Co-authored-by: Omer <ulrozremo@gmail.com>
@oschleic oschleic mentioned this pull request Sep 22, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oschleic @Eonasdan