Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netsim scenarios #27

Merged
merged 22 commits into from
Nov 30, 2022
Merged

Netsim scenarios #27

merged 22 commits into from
Nov 30, 2022

Conversation

AdrienLeGuillou
Copy link
Member

@AdrienLeGuillou AdrienLeGuillou commented Nov 8, 2022

make a netsim_scenarios function on EpiModel HPC that mimics the behavior of the step_tmpl_netsim_scenarios template for slurmworkflow.

It is designed to use the same underlying code as the step template and to fail on a similar fashion when it should.

  • initial design
  • documentation
  • formal tests
  • updates to the vignettes

@AdrienLeGuillou
Copy link
Member Author

This PR is functionally ready.
I'd like not to update the Vignette yet and instead work on the wiki related to this EpiModelHIV-Template PR. Once it is done, it will be easier to see what should be left in the vignette and what should go.
For now the vignette is still relevant, just not covering all the new functionalities. Updating for that implies heavily modifying the BigNet project.

@AdrienLeGuillou AdrienLeGuillou marked this pull request as ready for review November 29, 2022 14:42
@smjenness
Copy link
Collaborator

@AdrienLeGuillou : merging now, but maybe you want to create a new issue related to vignette/documentation?

@smjenness smjenness merged commit d3e43f7 into main Nov 30, 2022
@smjenness smjenness deleted the netsim_scenarios branch November 30, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants