Do not close the executor after workon #863

Epistimio · Dec 12, 2022 · 1de9135 · 1de9135
1 parent a994595
commit 1de9135
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 5 deletions.
diff --git a/src/orion/client/experiment.py b/src/orion/client/experiment.py
@@ -812,11 +812,7 @@ def workon(
                 **kwargs,
             )
 
-            if self._executor is None or self._executor_owner:
-                with self.executor:
-                    rval = runner.run()
-            else:
-                rval = runner.run()
+            rval = runner.run()
 
         return rval
 

diff --git a/tests/unittests/client/test_experiment_client.py b/tests/unittests/client/test_experiment_client.py
@@ -959,3 +959,19 @@ def test_user_executor_is_not_deleted():
 
     future = executor.submit(function, 2, 2)
     assert future.get() == 4, "Executor was not closed & can still be used"
+
+
+def main(*args, **kwargs):
+    return [dict(name="objective", type="objective", value=101)]
+
+
+def test_run_experiment_twice():
+    """"""
+
+    with create_experiment(config, base_trial) as (cfg, experiment, client):
+        client.workon(main, max_trials=10)
+
+        client._experiment.max_trials = 20
+        client._experiment.algorithms.algorithm.max_trials = 20
+
+        client.workon(main, max_trials=20)