From 815c9efb1fd1071448c5b2e8c49bcd401f3e2e54 Mon Sep 17 00:00:00 2001 From: Johan Henkens Date: Fri, 11 Apr 2014 19:33:19 -0700 Subject: [PATCH 1/3] Added .rb to migrations --- lib/generators/active_record/rolify_generator.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/generators/active_record/rolify_generator.rb b/lib/generators/active_record/rolify_generator.rb index 8dfd6ea3..a6015b77 100644 --- a/lib/generators/active_record/rolify_generator.rb +++ b/lib/generators/active_record/rolify_generator.rb @@ -17,7 +17,7 @@ def inject_role_class end def copy_rolify_migration - migration_template "migration.rb", "db/migrate/rolify_create_#{table_name}" + migration_template "migration.rb", "db/migrate/rolify_create_#{table_name}.rb" end def join_table @@ -47,4 +47,4 @@ def model_content end end end -end \ No newline at end of file +end From 6a1aaaafb5cb38cb3cc6f2018de3178bf8014d49 Mon Sep 17 00:00:00 2001 From: Johan Henkens Date: Sun, 4 May 2014 12:31:44 -0700 Subject: [PATCH 2/3] Updated travis settings to specific rails version --- .travis.yml | 17 +++++++++++----- gemfiles/Gemfile.rails-3.2 | 7 +++++-- gemfiles/Gemfile.rails-4.0 | 6 ++++-- gemfiles/Gemfile.rails-4.1 | 40 ++++++++++++++++++++++++++++++++++++++ 4 files changed, 61 insertions(+), 9 deletions(-) create mode 100644 gemfiles/Gemfile.rails-4.1 diff --git a/.travis.yml b/.travis.yml index 79b13bfc..2ed77e7e 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,13 +1,14 @@ rvm: - 1.9.3 - - 2.0.0 - - 2.1.0 + - 2.0.0 + - 2.1.1 - rbx - jruby-19mode gemfile: - gemfiles/Gemfile.rails-3.2 - gemfiles/Gemfile.rails-4.0 + - gemfiles/Gemfile.rails-4.1 env: - ADAPTER=active_record @@ -16,10 +17,16 @@ env: services: mongodb matrix: + fast_finish: true exclude: - rvm: rbx - gemfile: gemfiles/Gemfile.rails-3.2 + gemfile: gemfiles/Gemfile.rails-3.2 env: ADAPTER=mongoid - rvm: rbx - gemfile: gemfiles/Gemfile.rails-4.0 - env: ADAPTER=mongoid \ No newline at end of file + gemfile: gemfiles/Gemfile.rails-4.0 + env: ADAPTER=mongoid + - rvm: rbx + gemfile: gemfiles/Gemfile.rails-4.1 + env: ADAPTER=mongoid + - rvm: 1.9.3 + gemfile: gemfiles/Gemfile.rails-4.1 diff --git a/gemfiles/Gemfile.rails-3.2 b/gemfiles/Gemfile.rails-3.2 index 19e027cf..541cf972 100644 --- a/gemfiles/Gemfile.rails-3.2 +++ b/gemfiles/Gemfile.rails-3.2 @@ -10,11 +10,14 @@ platforms :rbx do end group :test do + gem 'railties', '~> 3.2', '< 4.0' case ENV["ADAPTER"] when nil, "active_record" gem "activerecord-jdbcsqlite3-adapter", ">= 1.3.0.rc", :platform => "jruby" - gem "sqlite3", :platform => "ruby" - gem "activerecord", ">= 3.2.0", :require => "active_record" + #Fix sqlite3 version for rbx until rubinus is updated + #https://github.com/travis-ci/travis-ci/issues/2006 + gem "sqlite3", "1.3.8", :platform => "ruby" + gem "activerecord", "~> 3.2.0", :require => "active_record" when "mongoid" gem "mongoid", ">= 3.1" gem "bson_ext", :platform => "ruby" diff --git a/gemfiles/Gemfile.rails-4.0 b/gemfiles/Gemfile.rails-4.0 index 13cf23d3..61f89866 100644 --- a/gemfiles/Gemfile.rails-4.0 +++ b/gemfiles/Gemfile.rails-4.0 @@ -10,7 +10,7 @@ platforms :rbx do end group :test do - gem "rails", "~> 4.0.1" + gem "railties", "~> 4.0.1", '< 4.1' gem "ammeter" gem "rake" gem "rspec" @@ -24,7 +24,9 @@ group :test do when nil, "active_record" gem "activerecord", "~> 4.0.1", :require => "active_record" gem "activerecord-jdbcsqlite3-adapter", "~> 1.3.5", :platform => "jruby" - gem "sqlite3", :platform => "ruby" + #Fix sqlite3 version for rbx until rubinus is updated + #https://github.com/travis-ci/travis-ci/issues/2006 + gem "sqlite3", "1.3.8", :platform => "ruby" when "mongoid" gem "mongoid", github: 'mongoid/mongoid' gem "bson_ext", :platform => "ruby" diff --git a/gemfiles/Gemfile.rails-4.1 b/gemfiles/Gemfile.rails-4.1 new file mode 100644 index 00000000..fee63bd2 --- /dev/null +++ b/gemfiles/Gemfile.rails-4.1 @@ -0,0 +1,40 @@ +source "https://rubygems.org" + +platforms :rbx do + gem 'racc' + gem 'rubysl', '~> 2.0' + gem 'psych' + gem 'json' + gem 'rubinius-coverage', '~> 2.0' + gem 'rubysl-test-unit' +end + +group :test do + gem 'rails', github: 'rails/rails', branch: '4-1-stable' + # There is currently an active record bug in Rails 4.1.0, this is a workaround until 4.1.1 is released + # See https://github.com/rails/rails/issues/13648 + # Without this patch, Resource.with_role(:role, User.first).count throws an SQL syntax exception + #gem "railties", "~> 4.1.0" + gem "ammeter" + gem "rake" + gem "rspec" + gem "rspec-rails" + gem "fuubar" + gem "bundler" + + gem 'coveralls', :require => false + + case ENV["ADAPTER"] + when nil, "active_record" + gem "activerecord", "~> 4.1.0", :require => "active_record" + gem "activerecord-jdbcsqlite3-adapter", "~> 1.3.5", :platform => "jruby" + #Fix sqlite3 version for rbx until rubinus is updated + #https://github.com/travis-ci/travis-ci/issues/2006 + gem "sqlite3", "1.3.8", :platform => "ruby" + when "mongoid" + gem "mongoid", github: 'mongoid/mongoid' + gem "bson_ext", :platform => "ruby" + else + raise "Unknown model adapter: #{ENV["ADAPTER"]}" + end +end From fcd1e4eff9d6b2196de850eccd0d78ad95ac623f Mon Sep 17 00:00:00 2001 From: Johan Henkens Date: Mon, 12 May 2014 16:13:29 -0700 Subject: [PATCH 3/3] Updated rbx travis settings --- .travis.yml | 11 +---------- gemfiles/Gemfile.rails-3.2 | 4 ---- gemfiles/Gemfile.rails-4.0 | 4 ---- gemfiles/Gemfile.rails-4.1 | 4 ---- 4 files changed, 1 insertion(+), 22 deletions(-) diff --git a/.travis.yml b/.travis.yml index 2ed77e7e..5b350221 100644 --- a/.travis.yml +++ b/.travis.yml @@ -2,7 +2,7 @@ rvm: - 1.9.3 - 2.0.0 - 2.1.1 - - rbx + - rbx-2 - jruby-19mode gemfile: @@ -19,14 +19,5 @@ services: mongodb matrix: fast_finish: true exclude: - - rvm: rbx - gemfile: gemfiles/Gemfile.rails-3.2 - env: ADAPTER=mongoid - - rvm: rbx - gemfile: gemfiles/Gemfile.rails-4.0 - env: ADAPTER=mongoid - - rvm: rbx - gemfile: gemfiles/Gemfile.rails-4.1 - env: ADAPTER=mongoid - rvm: 1.9.3 gemfile: gemfiles/Gemfile.rails-4.1 diff --git a/gemfiles/Gemfile.rails-3.2 b/gemfiles/Gemfile.rails-3.2 index 541cf972..02bd92f0 100644 --- a/gemfiles/Gemfile.rails-3.2 +++ b/gemfiles/Gemfile.rails-3.2 @@ -1,12 +1,8 @@ source "https://rubygems.org" platforms :rbx do - gem 'racc' - gem 'rubysl', '~> 2.0' gem 'psych' - gem 'json' gem 'rubinius-coverage', '~> 2.0' - gem 'rubysl-test-unit' end group :test do diff --git a/gemfiles/Gemfile.rails-4.0 b/gemfiles/Gemfile.rails-4.0 index 61f89866..262ece7b 100644 --- a/gemfiles/Gemfile.rails-4.0 +++ b/gemfiles/Gemfile.rails-4.0 @@ -1,12 +1,8 @@ source "https://rubygems.org" platforms :rbx do - gem 'racc' - gem 'rubysl', '~> 2.0' gem 'psych' - gem 'json' gem 'rubinius-coverage', '~> 2.0' - gem 'rubysl-test-unit' end group :test do diff --git a/gemfiles/Gemfile.rails-4.1 b/gemfiles/Gemfile.rails-4.1 index fee63bd2..35cbb62b 100644 --- a/gemfiles/Gemfile.rails-4.1 +++ b/gemfiles/Gemfile.rails-4.1 @@ -1,12 +1,8 @@ source "https://rubygems.org" platforms :rbx do - gem 'racc' - gem 'rubysl', '~> 2.0' gem 'psych' - gem 'json' gem 'rubinius-coverage', '~> 2.0' - gem 'rubysl-test-unit' end group :test do