Skip to content
Permalink
Browse files

don't do a pants run on osx (pantsbuild#7278)

### Problem

Fixes pantsbuild#7247, catching a case that was otherwise missed.

### Solution

- Don't do a `./pants run` on osx using the gnu toolchain in testing, as it doesn't work yet.

### Result

As noted in pantsbuild#7249, it's strange that that PR passes but the nightly job fails -- it may be nondeterministic.
  • Loading branch information...
cosmicexplorer committed Feb 23, 2019
1 parent a86639e commit a87a01b0f75e08046c6a2739875db675d87198ed
Showing with 12 additions and 0 deletions.
  1. +12 −0 tests/python/pants_test/backend/python/tasks/native/test_ctypes_integration.py
@@ -229,6 +229,18 @@ def test_native_compiler_option_sets_integration(self, toolchain_variant):
This target uses the ndebug and asdf option sets.
If either of these are not present (disabled), this test will fail.
"""
# TODO(#6848): this fails when run with gcc on osx as it requires gcc's libstdc++.so.6.dylib to
# be available on the runtime library path.
attempt_pants_run = Platform.create().resolve_for_enum_variant({
'darwin': toolchain_variant.resolve_for_enum_variant({
'gnu': False,
'llvm': True,
}),
'linux': True,
})
if not attempt_pants_run:
return

command = [
'run',
self._binary_target_with_compiler_option_sets

0 comments on commit a87a01b

Please sign in to comment.
You can’t perform that action at this time.