Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new maps #45

Merged
merged 5 commits into from
Dec 6, 2020
Merged

add new maps #45

merged 5 commits into from
Dec 6, 2020

Conversation

hyuunnn
Copy link
Contributor

@hyuunnn hyuunnn commented Dec 6, 2020

No description provided.

Description: Terminated due to non-response
EventId: 10002
Channel: "Application"
Maps:
Copy link
Sponsor Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a Provider for the Application log maps? There are many Providers with overlapping event IDs sometimes so it's best practice to ensure Provider is populated for Application.evtx maps.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed :)

Values:
-
Name: Data
Value: "/Event/EventData/Data"
Copy link
Sponsor Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test this? Did it grab data? It looks different than most other maps on this line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

It works correctly.

Copy link
Sponsor Collaborator

@AndrewRathbun AndrewRathbun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI Security 4723 already exists as of yesterday. Please review that one and ensure everything is covered. Make changes as you see fit. Two eyes are better than one on any map(s). Thanks for your contributions, keep it up!

@hyuunnn
Copy link
Contributor Author

hyuunnn commented Dec 6, 2020

Oh sorry.. I'll clean up and upload again.

@AndrewRathbun AndrewRathbun merged commit a8124a1 into EricZimmerman:master Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants