Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SDP such that h264 is negotiated with Firefox. #508

Closed
wants to merge 1 commit into from
Closed

Make SDP such that h264 is negotiated with Firefox. #508

wants to merge 1 commit into from

Conversation

stefhak
Copy link
Contributor

@stefhak stefhak commented Nov 2, 2015

However, I don't think it should be merged since it seems quite unstable, it seems owr often stops decoding after a short while (leaving a frozen video). Output in console (where openwebrtc-daemon is run):

(<unknown>:50476): libnice-WARNING **: Could not find component 2 in stream 1

** (<unknown>:50476): WARNING **: (owr_transport_agent.c:2414):on_new_remote_candidate: runtime check failed: (cands_added > 0)

(<unknown>:50476): libnice-WARNING **: Could not find component 2 in stream 1

** (<unknown>:50476): WARNING **: (owr_transport_agent.c:2414):on_new_remote_candidate: runtime check failed: (cands_added > 0)

(<unknown>:50476): libnice-WARNING **: Could not find component 2 in stream 1

** (<unknown>:50476): WARNING **: (owr_transport_agent.c:2414):on_new_remote_candidate: runtime check failed: (cands_added > 0)

(<unknown>:50476): GStreamer-CRITICAL **: gst_object_unref: assertion '((GObject *) object)->ref_count > 0' failed

(<unknown>:50476): GStreamer-CRITICAL **: gst_object_unref: assertion '((GObject *) object)->ref_count > 0' failed

(<unknown>:50476): GStreamer-CRITICAL **: gst_object_unref: assertion '((GObject *) object)->ref_count > 0' failed

@stefhak
Copy link
Contributor Author

stefhak commented Nov 11, 2015

Closing since this was apparently already merged. However, in my experience this gives issues (often the FF open264 plugin crashes) so I'm not sure it was a good move to merge.

@stefhak stefhak closed this Nov 11, 2015
@superdump
Copy link
Contributor

We should really expose the actual profile/level based on caps rather than hardcoding something.

@stefhak
Copy link
Contributor Author

stefhak commented Nov 11, 2015

Agree, and given how often FF crashes when h264 is negotiated with this fix I think we should undo it (we're better off using VP8 for the time being).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants