{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":745599433,"defaultBranch":"master","name":"knex","ownerLogin":"ErinCall","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2024-01-19T17:25:06.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/21196?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1705685131.0","currentOid":""},"activityList":{"items":[{"before":"d69d9dccd0d964eac19d96a0452643760707deb6","after":"9a8e9af0fec73d68751fd90d1bcd8d534febaece","ref":"refs/heads/for-update-of-schema","pushedAt":"2024-01-19T19:16:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ErinCall","name":"Erin Call","path":"/ErinCall","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/21196?s=80&v=4"},"commit":{"message":"Remove leftover console.log\n\nTurns out your changes only show up in git if you press \"save\" in your\neditor. Who knew!","shortMessageHtmlLink":"Remove leftover console.log"}},{"before":null,"after":"d69d9dccd0d964eac19d96a0452643760707deb6","ref":"refs/heads/for-update-of-schema","pushedAt":"2024-01-19T17:25:31.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ErinCall","name":"Erin Call","path":"/ErinCall","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/21196?s=80&v=4"},"commit":{"message":"Fix FOR UPDATE OF with explicit schema (#5053)\n\nWhen the _tableNames helper was written there were multiple methods\nhitting it, but they've since been merged into the single _lockingClause\nmethod. Given that the only really interesting thing it was doing was\nprepending the schema name--which is the incorrect behavior this commit\nfixes--it didn't seem worth keeping at this point.\n\nI'm not sure you'd say `.withSchema('public')` in a real query but it\nlets me exercise the behavior in question without having to learn enough\nabout knex's test environment to stand up a discrete schema. I suppose\nit's plausible that a reasonable maintainer would go \"hm that's silly\nand redundant\" and inadvertently remove coverage for this bug, though.","shortMessageHtmlLink":"Fix FOR UPDATE OF with explicit schema (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1164904062\" data-permission-text=\"Title is private\" data-url=\"https://github.com/knex/knex/issues/5053\" data-hovercard-type=\"issue\" data-hovercard-url=\"/knex/knex/issues/5053/hovercard\" href=\"https://github.com/knex/knex/issues/5053\">knex#5053</a>)"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAD5EjKogA","startCursor":null,"endCursor":null}},"title":"Activity · ErinCall/knex"}