Added new matchers for MongoDB. #71

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants

kotedo commented Mar 26, 2013

No description provided.

Contributor

evanmiller commented Mar 26, 2013

Hi Kai,

I don't really like this approach because options can't be combined... how do I get both "s" and "x", for example?

Also, it's important to expose a consistent API across all adapters. The weird leading "*" isn't PCRE compatible, but it is supported across BossDB. If we're going to change it, it needs to be changed across the board.

One possibility is to put the options as the fourth tuple element, e.g.

{foo, 'matches', "bar", "im"}

The problem with this approach is that it doesn't work with the LINQ-style query syntax like

foo ~ "bar"

Although maybe that could be

foo ~ {"bar", "im"}

kotedo commented Mar 26, 2013

Okay, I am open for suggestions.

I am certain that "m" is case insensitive on MongoDB.
That would eliminate the need to add the fourth element to the tuple.

Contributor

evanmiller commented Mar 28, 2013

Hi Kai,

Are you saying none of the options can be combined? "im", "is", "ix", "sx", and "sm" would never occur?

kotedo commented Mar 28, 2013

Hi Evan,

I'll double check, but I am almost certain that they can't be combined.
"M" for multiline searches case insensitive for sure. I'll verify the
other combinations and let you know ASAP.

--Kai

On Wednesday, March 27, 2013, Evan Miller wrote:

Hi Kai,

Are you saying none of the options can be combined? "im", "is", "ix",
"sx", and "sm" would never occur?


Reply to this email directly or view it on GitHubhttps://github.com/evanmiller/boss_db/pull/71#issuecomment-15564497
.

kotedo commented May 22, 2013

Closing it. Better solution by Evan. Thanks!

kotedo closed this May 22, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment