New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spine-ts: fix dark in both pma and non-pma #993

Merged
merged 1 commit into from Sep 28, 2017

Conversation

Projects
None yet
3 participants
@ivanpopelyshev
Contributor

ivanpopelyshev commented Sep 14, 2017

#992

According to my calculations, both modes were wrong. I do not know about other runtimes.

To make shader work in both modes, I've added v_dark.a = 1.0 in PMA, 0.0 in non-PMA.

PMA mode

  • FIX 1.0 switched to texColor.a , because that's what math says
  • IMPROVEMENT premultiply dark.rgb to alpha

NON-PMA

  • FIX alpha should not affect rgb at all

@ivanpopelyshev ivanpopelyshev changed the title from fix dark in both pma and non-pma to spine-ts: fix dark in both pma and non-pma Sep 14, 2017

@ivanpopelyshev

This comment has been minimized.

Show comment
Hide comment
@ivanpopelyshev

ivanpopelyshev Sep 18, 2017

Contributor

Its interesting that the same thing can be reproduced with http://help.adobe.com/en_US/FlashPlatform/reference/actionscript/3/flash/geom/ColorTransform.html , however, it would not allow to invert the colors. At the same time, dark-light wont allow to decrease the specific color.

Contributor

ivanpopelyshev commented Sep 18, 2017

Its interesting that the same thing can be reproduced with http://help.adobe.com/en_US/FlashPlatform/reference/actionscript/3/flash/geom/ColorTransform.html , however, it would not allow to invert the colors. At the same time, dark-light wont allow to decrease the specific color.

@badlogic badlogic merged commit 8506e16 into EsotericSoftware:3.6 Sep 28, 2017

@NathanSweet NathanSweet removed the bug label Sep 28, 2017

@badlogic badlogic removed the bug label Sep 28, 2017

@badlogic

This comment has been minimized.

Show comment
Hide comment
@badlogic

badlogic Sep 28, 2017

Contributor

Thank you kind sir!

Contributor

badlogic commented Sep 28, 2017

Thank you kind sir!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment