From 5f75eeec755a4d123c0d225ae4fb15c95de267f7 Mon Sep 17 00:00:00 2001
From: EsraDoerksen <esra.doerksen@pax.ch>
Date: Sun, 29 Oct 2023 11:49:36 +0100
Subject: [PATCH 1/2] adds correct wording

---
 .../components/big-expenses/big-expenses.component.html   | 8 ++++----
 .../contract-expenses/contract-expenses.component.html    | 8 ++++----
 .../regular-expenses/regular-expenses.component.html      | 8 ++++----
 3 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/bank-advisor/src/app/components/big-expenses/big-expenses.component.html b/bank-advisor/src/app/components/big-expenses/big-expenses.component.html
index b18a6c6..638ff68 100644
--- a/bank-advisor/src/app/components/big-expenses/big-expenses.component.html
+++ b/bank-advisor/src/app/components/big-expenses/big-expenses.component.html
@@ -1,8 +1,8 @@
 <div class="margin-x mt-3">
   <h1 class="display-5">Big expenses</h1>
   <p>
-    Those are the transactions, which have a big spending amount. You should
-    analyze what you are spending your money on.
+    Those are the transactions, which have a big spending amount. Let's have a
+    look at your big transactions:
   </p>
 
   <ul *ngFor="let bigTransaction of bigTransactions" class="list-group">
@@ -39,8 +39,8 @@ <h5 class="card-title">{{ bigTransaction.description }}</h5>
         <div class="card-body">
           <h5 class="card-title">Big saving potential</h5>
           <p class="card-text">
-            We can see, that you bought a lot of electronics in the past! There
-            are other options. Secondary buys and toppreise.ch
+            We can see, that you bought a lot of electronics in the past! You
+            can save a lot of money through secondary buys and toppreise.ch
           </p>
         </div>
       </div>
diff --git a/bank-advisor/src/app/components/contract-expenses/contract-expenses.component.html b/bank-advisor/src/app/components/contract-expenses/contract-expenses.component.html
index 4cabe71..00e6d23 100644
--- a/bank-advisor/src/app/components/contract-expenses/contract-expenses.component.html
+++ b/bank-advisor/src/app/components/contract-expenses/contract-expenses.component.html
@@ -1,8 +1,8 @@
 <div class="margin-x mt-3">
   <h1 class="display-5">Contract expenses</h1>
   <p>
-    Those are the transactions, which are bound to a contract. Are those
-    contract really the best.
+    Those are the transactions, which are bound to a contract. Let's have a look
+    at your contracts:
   </p>
 
   <ul *ngFor="let transaction of this.contractTransactions" class="list-group">
@@ -38,8 +38,8 @@ <h5 class="card-title">{{ transaction.description }}</h5>
         <div class="card-body">
           <h5 class="card-title">Big saving potential</h5>
           <p class="card-text">
-            We can see, that you bought a lot of electronics in the past! There
-            are other options. Secondary buys and toppreise.ch
+            We can see, that you purchased multiple contracts in the past! You
+            can save a lot of money through comparis.ch
           </p>
         </div>
       </div>
diff --git a/bank-advisor/src/app/components/regular-expenses/regular-expenses.component.html b/bank-advisor/src/app/components/regular-expenses/regular-expenses.component.html
index 78c5b90..8b76982 100644
--- a/bank-advisor/src/app/components/regular-expenses/regular-expenses.component.html
+++ b/bank-advisor/src/app/components/regular-expenses/regular-expenses.component.html
@@ -1,8 +1,8 @@
 <div class="margin-x mt-3">
   <h1 class="display-5">Regular expenses</h1>
   <p>
-    Those are the transactions, which are regulary executed. You should ask
-    yoursef the question if that's really neccessary.
+    Those are the transactions, which are regulary executed. Let's have a look
+    at your regular transactions:
   </p>
 
   <ul *ngFor="let transaction of this.regularTransactions" class="list-group">
@@ -38,8 +38,8 @@ <h5 class="card-title">{{ transaction.description }}</h5>
         <div class="card-body">
           <h5 class="card-title">Big saving potential</h5>
           <p class="card-text">
-            We can see, that you bought a lot of electronics in the past! There
-            are other options. Secondary buys and toppreise.ch
+            We can see, that you bought a lot of electronics in the past! You
+            can save a lot of money through secondary buys and toppreise.ch
           </p>
         </div>
       </div>

From 2aa30fe61a18c4e4f16bc68244cae75651f85ce1 Mon Sep 17 00:00:00 2001
From: Benjamin <benjamin.bach2@pax.ch>
Date: Sun, 29 Oct 2023 12:42:08 +0100
Subject: [PATCH 2/2] fix

---
 bank/backend/src/app.service.ts       | 1 +
 dev-portal/backend/public/index.html  | 1 +
 dev-portal/backend/src/app.service.ts | 2 +-
 3 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/bank/backend/src/app.service.ts b/bank/backend/src/app.service.ts
index 2ea3df0..ce6bacb 100644
--- a/bank/backend/src/app.service.ts
+++ b/bank/backend/src/app.service.ts
@@ -30,6 +30,7 @@ export class AppService {
     const response = await firstValueFrom(
       this.httpService.get(`${this.configService.devPortalRootUrl}/apps`),
     );
+    console.log(response.data);
     return response.data;
   }
 }
diff --git a/dev-portal/backend/public/index.html b/dev-portal/backend/public/index.html
index 6b3f823..2ecc57f 100644
--- a/dev-portal/backend/public/index.html
+++ b/dev-portal/backend/public/index.html
@@ -14,6 +14,7 @@
         const appId = urlParams.get('appId');
         window.sessionStorage.setItem('appId', appId);
         window.location.href = `https://dev-o8lopd1x78xgb35o.us.auth0.com/authorize?client_id=${clientId}&redirect_uri=http%3A%2F%2Flocalhost%3A3001&response_type=code&scope=openid%20profile%20email%20offline_access`;
+        return;
       }
 
       const data = new URLSearchParams();
diff --git a/dev-portal/backend/src/app.service.ts b/dev-portal/backend/src/app.service.ts
index dfbee79..3a91f5f 100644
--- a/dev-portal/backend/src/app.service.ts
+++ b/dev-portal/backend/src/app.service.ts
@@ -17,7 +17,7 @@ export class AppService {
     const apps = await this.appRepository.find();
     return apps.map((app) => ({
       ...app,
-      url: `http://localhost:3001?${app.appId}`,
+      url: `http://localhost:3001?appId=${app.appId}`,
     }));
   }