circles are still not being closed with Circle. New failing test illustrates it. #234

Merged
merged 1 commit into from Feb 20, 2014

Conversation

Projects
None yet
2 participants
Contributor

markstos commented Feb 6, 2014

The previous test syntax was not working as intended because it was not
taking into account the nesting of the coordinates structure.

If you simply dump out the entire coordinate list returned, you can see
that the last point is not the same as the first point, as it should be.

This test update correctly takes the nesting into account and tests
both the latitude and longitude.

New failing test: After this test is fixed to work as intended, it sh…
…ows that the Circle is still not producing closed circles

The previous test syntax was not working as intended because it was not
taking into account the nesting of the coordinates structure.

If you simply dump out the entire coordinate list returned, you can see
that the last point is not the same as the first point, as it should be.

This test update correctly takes the nesting into account and tests
both the latitude and longitude.
Contributor

markstos commented Feb 19, 2014

The fact that circles are confirmed to be calculated incorrectly seems fairly important. Any progress on this? Is help needed with the patch?

Member

patrickarlt commented Feb 20, 2014

@markstos sorry this has slipped through the cracks. I can probably patch this this before the week is out.

Going to merge this though, thanks for the failing test.

patrickarlt added a commit that referenced this pull request Feb 20, 2014

Merge pull request #234 from markstos/circle-still-not-closed
circles are still not being closed with Circle.  New failing test illustrates it.

@patrickarlt patrickarlt merged commit 2ee3416 into Esri:master Feb 20, 2014

Member

patrickarlt commented Feb 24, 2014

@markstos Fixed in 1.0.3

Contributor

markstos commented Feb 25, 2014

Thanks! I'll give it a test drive.

On 2/24/14, Patrick Arlt notifications@github.com wrote:

@markstos Fixed in 1.0.3


Reply to this email directly or view it on GitHub:
Esri#234 (comment)

Mark Stosberg
Senior Systems Engineer
RideAmigos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment