Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rollup): bump to the latest version of rollup #141

Merged
merged 3 commits into from Mar 3, 2018
Merged

Conversation

jgravois
Copy link
Contributor

@jgravois jgravois commented Mar 2, 2018

to support multiple output files (and make sure to ship our copyright notice)

i thought i was laying the groundwork for #135, but TrySound/rollup-plugin-uglify#1 indicates that we'll need to spin up two different instances of rollup to create both built and unbuilt output.

ISSUES CLOSED: #136

to support multiple output files

ISSUES CLOSED: #136
@coveralls
Copy link

coveralls commented Mar 2, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 302fa85 on patch135 into e2b05b2 on master.

AFFECTS PACKAGES:
@esri/arcgis-rest-auth
@esri/arcgis-rest-feature-service
@esri/arcgis-rest-geocoder
@esri/arcgis-rest-groups
@esri/arcgis-rest-items
@esri/arcgis-rest-request

ISSUES CLOSED: #135
@jgravois
Copy link
Contributor Author

jgravois commented Mar 3, 2018

pushed up another commit that kicks off two rollup commands for each package so that we can ship a second unminified UMD.

Copy link
Contributor

@patrickarlt patrickarlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jgravois these changes look good but it would be a good idea to point browser in each package to the unminifed file. That way the unminifed version will be picked up by whatever build system people are using which will make debugging easier.

@tomwayson
Copy link
Member

tomwayson commented Mar 3, 2018

I will make that change, and test that in the feature layer dummy app and cedar now.

@tomwayson
Copy link
Member

tomwayson commented Mar 3, 2018

I was going to point browser to the unminified file as per @patrickarlt's suggestion, but it seemed odd to have that pointing to a file w/ "debug" in the name. I think it's more common to specify the minified files w/ .min.js - take bootstrap for example. So I updated the profiles accordingly. This meant that I didn't need to update the browser field of all the package.json files.

I tested this w/ both the features sservice demo app, and a branch of cedar configured to treat arcgis-rest-* as external, and it works w/ both the unminified and minified files.

@jgravois jgravois merged commit f4411c3 into master Mar 3, 2018
@jgravois jgravois deleted the patch135 branch March 3, 2018 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants