refactor(action): large component needs to match figma design #2786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the semantic PR, you'll need to get a new commit to pass that check.
|
|
All the tests passed this time. Thanks for letting me know I missed that colon in the commit message. |
jcfranco
changed the title
|
This one is blocked by #2736 |
2 tasks
|
@caripizza created an issue aimed specifically at the font-size that this PR might address. |
github-actions
bot
added
the
refactor
asangma
requested changes
Sep 2, 2021
There was a problem hiding this comment.
Sorry @justinhough.
Just realized we need to add margin styles for each scale when it's RTL (calcite--rtl).
There's one style there, but it looks like it's for scale M and not specific to that scale.
|
@asangma Just added the update. Let me know. |
|
👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #2458
Summary
updated large calcite-action to match Figma for sizing and spacing from icon.