Toggle Switch: Add attribute selector to input #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oknoway
force-pushed
the
toggle-switch-input
branch
from
14bb16e
to
4070e89
Compare
paulcpederson
approved these changes
Aug 24, 2018
|
adding @macandcheese as reviewer |
oknoway
force-pushed
the
toggle-switch-input
branch
from
4070e89
to
55443c9
Compare
|
Looks good now, thanks for the fix. ⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
input[type="checkbox"], input[type="radio]"in_forms.scssoverrides the.toggle-switch-inputstyles. In some instances, this leads to.toggle-switch-inputbecoming visible.Adding an empty attribute selector gives
.toggle-switch-inputenough weight to override.