New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget generator should prompt for all widget properties #6

Closed
tomwayson opened this Issue Jun 13, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@tomwayson
Member

tomwayson commented Jun 13, 2014

Currently only prompts for inPanel, but could prompt for all of the following and only build out the required files. Since all are booleans and default to true, could be done w/ one checklist prompt that defaults to checked, like:

[x] inPanel
[x] hasLocale
[x] hasStyle
[x] hasConfig
[x] hasUIFile
[x] hasSettingPage

If hasSettingsPage is checked, then could show a second prompt w/ the following (defaulting to answers from above for hasUIFile, hasLocale, and hasStyle):

[x] hasSettingUIFile
[x] hasSettingLocale
[x] hasSettingStyle

Based on the answers from above, the generator would create the appropriate files and update the properties object in manifest.json and clazz object as needed.

While this would be simple to implement (aside from basing the second pompt on answers from the first), writing tests for the un/checked state of each could be time consuming.

@qlqllu

This comment has been minimized.

Show comment
Hide comment
@qlqllu

qlqllu Jun 26, 2014

Only manifest.json need these properties, clazz object doesn't need them. We put these properties in clazz object in the very early version.

qlqllu commented Jun 26, 2014

Only manifest.json need these properties, clazz object doesn't need them. We put these properties in clazz object in the very early version.

@tomwayson

This comment has been minimized.

Show comment
Hide comment
@tomwayson

tomwayson Jun 26, 2014

Member

Great, thanks @qlqllu!

Member

tomwayson commented Jun 26, 2014

Great, thanks @qlqllu!

@tomwayson tomwayson added this to the v0.1.0 milestone Jun 26, 2014

@tomwayson tomwayson self-assigned this Jun 26, 2014

tomwayson added a commit to tomwayson/generator-esri-appbuilder-js that referenced this issue Jul 7, 2014

@tomwayson tomwayson referenced this issue Jul 7, 2014

Merged

v0.1.0 #14

@tomwayson tomwayson closed this in #14 Jul 7, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment