Deprecate this plugin as functionality is already available in NativeScript CLI

[rosen-vladimirov]

Hey,

First of all I would like to express my gratitude for creating this plugin. At the time it was created, this functionality was not available in NativeScript CLI out-of-the-box and this plugin helped many projects and application authors to achieve the desired result.
Some time after the plugin was created, we've introduced the same functionality in NativeScript CLI, i.e. - support for app.entitlements file in <path to App_Resources>/iOS dir, support for app.entitlements file from plugins and merging all these files in a single file inside <project dir>/platforms/ios.
As the functionality is already available in NativeScript CLI, maybe it is time to deprecate this plugin.

Also in NativeScript 6.0.0 release (coming soon), hooks are changed and this plugin will stop working. Instead of making it compatible with NativeScript 6.0.0 I think it will be better to just leave it as is and mark it as deprecated in npm and in its README.

What do you think?

Thanks again for the great work!

[corne-de-bruin]

Hi @rosen-vladimirov ,

Thank you for the feedback. If this functionality is integrated in the CLI I fully agree that we should deprecate this plugin. As soon as we start with migrating our apps to NativeScript 6.x we will test if our app.entitlements are still working fine and then deprecate the plugin.

[dlcole]

Sure would be nice to at least have a comment in readme about this. I'm upgrading to {N} 6.0 and spent over an hour chasing the build errors.