[DONE] Fix wrong url of paginated sub-themes #789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age2 have /channel/theme/subtheme url which lead to 404 -> fix to /channel/subtheme
Badatos
reviewed
Mar 23, 2023
Badatos
reviewed
Mar 23, 2023
|
suite aux remarques de @Badatos je me dis egalement qu'il faudrait passer par des données sous forme de dataset (data-url par exemple ou data-slug) plutot que par variables |
Badatos
approved these changes
Mar 24, 2023
ptitloup
added a commit
that referenced
this pull request
Apr 12, 2023
* 🐛 podfile fix pagination display (#787) * improve clean_video_files and code cleaning (#782) * Fix wrong url of paginated sub-themes (#789) * Add "help" command to makefile (#792) * Ptitloup/fix thumbnail (#790) * Hide channel desc (#794) * fix podfile (#798) * Correct podfile sidebar (#799) * Ptitloup/fix link playlist (#801) * Fix video theme (#800) --------- Co-authored-by: MattBild <34771705+mattbild@users.noreply.github.com> Co-authored-by: Olivier Bado-Faustin <bado@unice.fr> Co-authored-by: pampletousse <51699553+pampletousse@users.noreply.github.com>
vsabatie
pushed a commit
to vsabatie/Pod
that referenced
this pull request
Apr 20, 2023
* 🐛 podfile fix pagination display (EsupPortail#787) * improve clean_video_files and code cleaning (EsupPortail#782) * Fix wrong url of paginated sub-themes (EsupPortail#789) * Add "help" command to makefile (EsupPortail#792) * Ptitloup/fix thumbnail (EsupPortail#790) * Hide channel desc (EsupPortail#794) * fix podfile (EsupPortail#798) * Correct podfile sidebar (EsupPortail#799) * Ptitloup/fix link playlist (EsupPortail#801) * Fix video theme (EsupPortail#800) --------- Co-authored-by: MattBild <34771705+mattbild@users.noreply.github.com> Co-authored-by: Olivier Bado-Faustin <bado@unice.fr> Co-authored-by: pampletousse <51699553+pampletousse@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix wrong url of paginated sub-themes on page2 have /channel/theme/subtheme url which lead to 404 -> fix to /channel/subtheme