[DONE] Ptitloup/fix thumbnail #790

ptitloup · 2023-03-24T10:10:18Z

fix create thumbnail by getting the lower mp4 format

CONFIGURATION_FR.md

pod/video/Encoding_video.py

pod/video/Encoding_video_model.py

pod/video/Encoding_video.py

pod/video/templates/videos/video-script.html

pod/video/Encoding_video.py

…o refresh overview fi changed

pampletousse

Ok pour moi

ptitloup

tout me semble ok

mattbild · 2023-03-30T14:29:30Z

j'ai une erreur à la suppression d'une vidéo (testé 2 fois)

Cannot add or update a child row: a foreign key constraint fails (`pod`.`video_video`, CONSTRAINT `video_video_thumbnail_id_de05caf2_fk_podfile_customimagemodel_id` FOREIGN KEY (`thumbnail_id`) REFERENCES `podfile_customimagemodel` (`id`))

Je ne sais pas si c'est uniquement chez moi

ptitloup · 2023-03-30T14:45:11Z

Visio ?

mattbild · 2023-03-30T15:23:59Z

c'est bien sur cet env local qu'il y a des problèmes à la supp d'une vidéo.

Toutes les vidéos que je viens de tester ont bien des thumbnails générés et un affiché

CONFIGURATION_FR.md

… delete to remove all file for video

ptitloup

ok pour moi

pod/video/models.py

mattbild · 2023-03-31T12:27:00Z

A la suppression je n'ai plus les fichiers (sauf le dossier de la vidéo qui est vide)
mais j'ai encore l'entrée en base dans la table video_video
donc la vignette (sans thumbnail) est affichée dans la liste de mes vidéos

ptitloup · 2023-03-31T12:51:24Z

A la suppression je n'ai plus les fichiers (sauf le dossier de la vidéo qui est vide) mais j'ai encore l'entrée en base dans la table video_video donc la vignette (sans thumbnail) est affichée dans la liste de mes vidéos

je constate egalement ce dysfonctionnement

ptitloup · 2023-03-31T13:18:46Z

Je viens normalement de fixer ce dysfonctionnement, tout est bien supprimé maintenant

mattbild · 2023-03-31T13:27:45Z

Je viens normalement de fixer ce dysfonctionnement, tout est bien supprimé maintenant

c'est bon pour moi.
La vidéo n'apparait plus et n'existe plus en base.

…ing - remove field in video form if wiating for encoding

mattbild · 2023-03-31T14:11:11Z

ok :

les boutons de suppression de la vidéo n'apparaissent plus tant qu'elle est en cours d'encodage
on n'a plus l'erreur concernant le propriétaire de la vidéo quand on la modifie pendant l'encodage

ptitloup · 2023-03-31T14:12:14Z

ok :

* les boutons de suppression de la vidéo n'apparaissent plus tant qu'elle est en cours d'encodage

* on n'a plus l'erreur concernant le propriétaire de la vidéo quand on la modifie pendant l'encodage

Merci ! je dois encore verifier les tests unitaires et ca sera tout bon

pod/video/views.py

* 🐛 podfile fix pagination display (#787) * improve clean_video_files and code cleaning (#782) * Fix wrong url of paginated sub-themes (#789) * Add "help" command to makefile (#792) * Ptitloup/fix thumbnail (#790) * Hide channel desc (#794) * fix podfile (#798) * Correct podfile sidebar (#799) * Ptitloup/fix link playlist (#801) * Fix video theme (#800) --------- Co-authored-by: MattBild <34771705+mattbild@users.noreply.github.com> Co-authored-by: Olivier Bado-Faustin <bado@unice.fr> Co-authored-by: pampletousse <51699553+pampletousse@users.noreply.github.com>

* 🐛 podfile fix pagination display (EsupPortail#787) * improve clean_video_files and code cleaning (EsupPortail#782) * Fix wrong url of paginated sub-themes (EsupPortail#789) * Add "help" command to makefile (EsupPortail#792) * Ptitloup/fix thumbnail (EsupPortail#790) * Hide channel desc (EsupPortail#794) * fix podfile (EsupPortail#798) * Correct podfile sidebar (EsupPortail#799) * Ptitloup/fix link playlist (EsupPortail#801) * Fix video theme (EsupPortail#800) --------- Co-authored-by: MattBild <34771705+mattbild@users.noreply.github.com> Co-authored-by: Olivier Bado-Faustin <bado@unice.fr> Co-authored-by: pampletousse <51699553+pampletousse@users.noreply.github.com>

github-actions and others added 3 commits March 23, 2023 13:36

Fixup. Format code with Black

767d2db

Auto-update configuration files

ba00c19

fix create thumbnail by getting the lower mp4 format

4f9df5f

Badatos reviewed Mar 24, 2023

View reviewed changes

CONFIGURATION_FR.md Show resolved Hide resolved

Badatos reviewed Mar 24, 2023

View reviewed changes

pod/video/Encoding_video.py Outdated Show resolved Hide resolved

ptitloup added 4 commits March 27, 2023 15:12

fix create overview by getting the lower mp4 format

d96876e

create get_first_item def to DRY code

fb4c693

remove blank line

9b1629f

fix flake8 and return video when it modified for thumbnail and overview

c7f28db

Badatos reviewed Mar 27, 2023

View reviewed changes

pod/video/Encoding_video_model.py Outdated Show resolved Hide resolved

Badatos assigned ptitloup Mar 29, 2023

improve overview compute

5d42006

ptitloup mentioned this pull request Mar 29, 2023

Affichage des vignettes #786

Closed

ptitloup changed the title ~~[WIP] Ptitloup/fix thumbnail~~ [DONE] Ptitloup/fix thumbnail Mar 29, 2023

Badatos reviewed Mar 29, 2023

View reviewed changes

pod/video/Encoding_video.py Show resolved Hide resolved

Badatos reviewed Mar 29, 2023

View reviewed changes

pod/video/templates/videos/video-script.html Outdated Show resolved Hide resolved

add pydoc

603b5e3

Badatos reviewed Mar 30, 2023

View reviewed changes

pod/video/Encoding_video.py Outdated Show resolved Hide resolved

ptitloup added 3 commits March 30, 2023 14:06

fix space before inline comment and typo

f5e27cc

improve thumbnail attribution and remove unused video return value

defa75a

create tag to get last modified time and last created file - use it t…

5f6c5e8

…o refresh overview fi changed

pampletousse reviewed Mar 30, 2023

View reviewed changes

ptitloup commented Mar 30, 2023

View reviewed changes

Badatos approved these changes Mar 31, 2023

View reviewed changes

mattbild reviewed Mar 31, 2023

View reviewed changes

CONFIGURATION_FR.md Show resolved Hide resolved

fix typo in configuration

e2abc9c

mattbild approved these changes Mar 31, 2023

View reviewed changes

ptitloup added 2 commits March 31, 2023 12:42

refactoring create thumbnail in encoding video model

44bd47c

refactoring delete file when deleting video - use pre delete and post…

4372cbb

… delete to remove all file for video

ptitloup commented Mar 31, 2023

View reviewed changes

Badatos reviewed Mar 31, 2023

View reviewed changes

pod/video/models.py Show resolved Hide resolved

fix delete video after deleting files

e810d95

ptitloup added 3 commits March 31, 2023 15:55

user cannot delete video if encoding in progress or waiting for encod…

eb65ae6

…ing - remove field in video form if wiating for encoding

fix translation

33478df

add upper case

23a0ac3

ptitloup added 4 commits April 3, 2023 14:55

add encoding video in video app tests to get the right number of videos

38e0ed3

fix test adding video rendition

fc08b4a

remove video folder after deleting video

6b2daa7

fix test delete directory when video is deleted

3fb5c19

Badatos reviewed Apr 3, 2023

View reviewed changes

pod/video/views.py Outdated Show resolved Hide resolved

ptitloup added 2 commits April 3, 2023 16:39

update translation

b3a2f74

fix indent

8a55dd3

Badatos approved these changes Apr 3, 2023

View reviewed changes

ptitloup merged commit edfb546 into EsupPortail:develop Apr 3, 2023

[DONE] Ptitloup/fix thumbnail #790

[DONE] Ptitloup/fix thumbnail #790

Uh oh!

Conversation

ptitloup commented Mar 24, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pampletousse left a comment

Choose a reason for hiding this comment

Uh oh!

ptitloup left a comment

Choose a reason for hiding this comment

Uh oh!

mattbild commented Mar 30, 2023

Uh oh!

ptitloup commented Mar 30, 2023

Uh oh!

mattbild commented Mar 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

ptitloup left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mattbild commented Mar 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ptitloup commented Mar 31, 2023

Uh oh!

ptitloup commented Mar 31, 2023

Uh oh!

mattbild commented Mar 31, 2023

Uh oh!

mattbild commented Mar 31, 2023

Uh oh!

ptitloup commented Mar 31, 2023

Uh oh!

Uh oh!

Uh oh!

mattbild commented Mar 30, 2023 •

edited

Loading

mattbild commented Mar 31, 2023 •

edited

Loading