New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot run Etar from f-droid the first time #249

Closed
Fabiensk opened this Issue Aug 26, 2017 · 8 comments

Comments

Projects
None yet
4 participants
@Fabiensk

Fabiensk commented Aug 26, 2017

Scenario:

  • Install Etar from f-droid applications manager
  • Launch Etar from f-droid.
  • You are asked in a pop-up to give calendar access (click yes)

Actual result:

  • A "screen overlay detected" pop-up dialog is displayed, asking me to give Etar such a rights. Click on the button of the pop-up.
  • You are redirected to the Android "draw over other apps" system settings screen but there cannot change the overlay right for Etar
  • Leave the settings. Etar is not launched.

Expected result:
After having accepted to given the app access to the user calendar, Etar should be fully started.

Alternative scenario:
Like the original scenario, but by launching Etar from the Android applications list.

Additional notes:
It did not happen all the times when I repeated this scenario (must most of the times). Going in the Android application management and giving the Calendar, Contacts and Storage rights solved the issue. In some other attempts, trying to run the app several times (from the application list) sometimes succeeded (rights were properly added after being prompted).

Device: Samsung Galaxy S5 mini, Android 6.0.1
Etar version: 1.0.12 (f-droid)

@smichel17

This comment has been minimized.

Contributor

smichel17 commented Aug 26, 2017

Pretty sure this is not an issue with Etar. Are you running an app that uses an overlay? For example, (shameless plug) Red Moon. You need to turn off that app (or whatever feature of it uses an overlay) before you can grant permissions to any app, or your phone will behave as described.

@Etar-Group Etar-Group deleted a comment from smichel17 Aug 26, 2017

@jspricke

This comment has been minimized.

Member

jspricke commented Aug 26, 2017

It is actually a Etar problem, as there is code to display a notification why we need the calendar right.
If no one has an idea how to give this information without an overlay, we could fix it. Otherwise I would propose to simply remove the notification.

@smichel17

This comment has been minimized.

Contributor

smichel17 commented Aug 26, 2017

The notification in question is the one to grant calendar permissions. You can't remove it if you want calendar permissions. At least, that is how I understand it. Maybe @Fabiensk could provide a screenshot to confirm.

@Fabiensk

This comment has been minimized.

Fabiensk commented Aug 27, 2017

Typical attempt:

  • I just installed Etar. I press in f-droid the launch button (« Lancer » in French). I get the pop-up asking me to give access to the calendar. I press OK.
    f-droid 1

  • Then I get the overlay warning pop-up. I press « Open the settings ».
    f-droid 2

  • In the settings, I cannot allow Etar to use overlay. The only thing I can do in going back to f-droid.
    f-droid 3

  • Sometimes, after one or several attempts to launch Etar from f-droid, it actually run and I am asked to give access to the storage. If I accept, then I can use Etar.
    f-droid 4

I don't know much about Android development, but I suppose that Android is confused because the Etar UI is not launched yet and the access pop-up is displayed over another application. Maybe (only a theory) if it was possible to display Etar then get the permission pop-up it could solve the issue.

@jspricke

This comment has been minimized.

Member

jspricke commented Aug 27, 2017

Thanks for the screenshots, as I wrote it's an Etar problem. The code is here:

Toast.makeText(getApplicationContext(), R.string.user_rejected_calendar_write_permission, Toast.LENGTH_LONG).show();

We will probably remove it in the next version.

@smichel17

This comment has been minimized.

Contributor

smichel17 commented Aug 27, 2017

@Fabiensk can you clarify what the bug is by adding an expected result to compare with the actual result?

I interpreted the problem to be one thing, but @jspricke seems to have interpreted it differently, based on the proposed solution. So, I'm not sure any more what the actual bug is, or whether the proposed solution will solve it. I think it's a good idea to figure that out before we make changes :)

edit: typo

@keunes

This comment has been minimized.

keunes commented Nov 20, 2017

@jspricke I have no clue about coding, but are you proposing to remove the pop-up that requests for the necessary rights all together?
I'm asking this as I think it would be better to have this overlay problem (which exists for many apps) rather than letting the user clueless when something doesn't work because the necessary permissions aren't granted.

@jspricke

This comment has been minimized.

Member

jspricke commented Nov 21, 2017

No, I only proposed to remove the overlay, namely "Etar requires calendar read and write permissions to work properly. Please try again." But I didn't find time to try this, sorry.

@xsoh xsoh closed this in 9334679 Jan 8, 2018

jspricke added a commit to jspricke/Etar-Calendar that referenced this issue May 13, 2018

Don't initialize the widget without a calendar permission
This solves the second part of the crash on first start, reported in Etar-Group#249.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment