Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #149: assertion error message for non-existent events #150

Closed
wants to merge 1 commit into from

Conversation

@hbarcelos
Copy link
Contributor

hbarcelos commented Nov 1, 2019

  • Check for non-existent events on emit assertion helper to provide proper feedback.
const eventDescription = contract.interface.events[eventName];

if (eventDescription === undefined) {
const isNegated = this.__flags.negate === true;

This comment has been minimized.

Copy link
@hbarcelos

hbarcelos Nov 1, 2019

Author Contributor

I'm not sure this is the way to go when extending chai with a plugin. Couldn't find much information in the docs.

@sz-piotr

This comment has been minimized.

Copy link
Collaborator

sz-piotr commented Nov 8, 2019

Merged as part of #151

@sz-piotr sz-piotr closed this Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.