Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about page dropdown #842

Merged
merged 7 commits into from May 3, 2023
Merged

about page dropdown #842

merged 7 commits into from May 3, 2023

Conversation

JustinStitt
Copy link
Collaborator

Fix dropdown behavior

Old Behavior

dropdown-old
notice the jumps and ability to click invisible options!

New Behavior

dropdown
much nicer 😄

Also added new on hover effect for team members

hover1

@netlify
Copy link

netlify bot commented Apr 26, 2023

Deploy Preview for acmcsuf ready!

Name Link
🔨 Latest commit 59ee1a5
🔍 Latest deploy log https://app.netlify.com/sites/acmcsuf/deploys/64523afdbb3056000863ebc4
😎 Deploy Preview https://deploy-preview-842--acmcsuf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

src/lib/components/select/select.svelte Outdated Show resolved Hide resolved
jaasonw
jaasonw previously requested changes May 3, 2023
src/routes/(site)/wave1/+page.svelte Outdated Show resolved Hide resolved
Copy link
Collaborator

@jjoeldaniel jjoeldaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - the j's

@jjoeldaniel jjoeldaniel dismissed jaasonw’s stale review May 3, 2023 10:41

looked good to me

@jjoeldaniel jjoeldaniel enabled auto-merge (squash) May 3, 2023 10:43
@jjoeldaniel jjoeldaniel merged commit e65940f into main May 3, 2023
6 checks passed
@jjoeldaniel jjoeldaniel deleted the about-page-dropdown branch May 3, 2023 10:47
@jaasonw
Copy link
Contributor

jaasonw commented May 3, 2023

ur a stale revirew

@karnikaavelumani
Copy link
Collaborator

Thank you for catching this and for the PR.

Make sure to check what files you're committing next time because you pushed some changes into prod that weren't approved yet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants