New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #20

Merged
merged 4 commits into from Aug 3, 2018

Conversation

Projects
None yet
2 participants
@dmalt
Collaborator

dmalt commented Aug 2, 2018

Fixed smoothing behavior.
Also fixed hemisphere indexing inside add_activation (it used to break when I changed hemisphere to 'both' in the meg_inverse_solution example).
I tested some corner cases but I didn't write or run any unit tests.

@dmalt

This comment has been minimized.

Show comment
Hide comment
@dmalt

dmalt Aug 2, 2018

Collaborator

Had to modify this function since it was breaking add_activation when all vertices were below the hide_under threshold

Collaborator

dmalt commented on e13694c Aug 2, 2018

Had to modify this function since it was breaking add_activation when all vertices were below the hide_under threshold

@dmalt dmalt closed this Aug 2, 2018

@dmalt dmalt reopened this Aug 2, 2018

@dmalt

This comment has been minimized.

Show comment
Hide comment
@dmalt

dmalt Aug 3, 2018

Collaborator

Can I merge now?

Collaborator

dmalt commented Aug 3, 2018

Can I merge now?

Repository owner deleted a comment from codecov bot Aug 3, 2018

@EtienneCmb EtienneCmb merged commit f535cc0 into EtienneCmb:develop Aug 3, 2018

2 of 4 checks passed

codecov/patch 37.03% of diff hit (target 87.02%)
Details
codecov/project 86.97% (-0.06%) compared to 9f54d94
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment