Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TN3270 out of bounds write #605

Merged
merged 2 commits into from Dec 16, 2014
Merged

Conversation

NickSampanis
Copy link
Contributor

write to out of bounds of buffers if the username or password does not provided

@LocutusOfBorg
Copy link
Contributor

Travis is not happy about this pull request
https://travis-ci.org/Ettercap/ettercap/jobs/38270066

@NickSampanis
Copy link
Contributor Author

it seems that the return should be return NULL, but i am going to make another pull request with all the commits as you requested. There is another bug which i haven't committed and has impact on many dissectors

@LocutusOfBorg
Copy link
Contributor

You don't need to close the open pull request, you can just choose one and add commits there :-)
(the new commits I mean, the old can be merged as they are now)

LocutusOfBorg added a commit that referenced this pull request Dec 16, 2014
Fix TN3270 out of bounds write
@LocutusOfBorg LocutusOfBorg merged commit 3cef8ac into Ettercap:master Dec 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants