Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cvs ignore base64 error value #610

Merged
merged 1 commit into from Dec 16, 2014
Merged

Conversation

NickSampanis
Copy link
Contributor

base64decoder migth return -1, so the addition end_cred = cred+i might end up doing end_cred less than cred. so the expression while(*p && p!=cred_end) p++; may lead to accessing invalid memory, unless if we find a null character

@LocutusOfBorg
Copy link
Contributor

can you please add commits in a single pull request? we are getting a ton of mails, and having them together in my opinion helps a lot in code review! thanks

LocutusOfBorg added a commit that referenced this pull request Dec 16, 2014
Fix cvs ignore base64 error value
@LocutusOfBorg LocutusOfBorg merged commit ce3858f into Ettercap:master Dec 16, 2014
@LocutusOfBorg
Copy link
Contributor

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants