Unbreak build against Boost 1.67 #170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
lib/libuhd.so.3.12: undefined reference to `gps_ctrl_impl::GPSDO_COMMAND_DELAY_MS'
lib/libuhd.so.3.12: undefined reference to `uhd::usrprio_rpc::usrprio_rpc_client::DEFAULT_TIMEOUT_IN_MS'
lib/libuhd.so.3.12: undefined reference to `uhd::niusrprio::niusrprio_session::FPGA_READY_TIMEOUT_IN_MS'
host/lib/usrp/cores/rx_vita_core_3000.cpp:67:35: error: no matching conversion for functional-style cast from 'double' to 'boost::posix_time::milliseconds' (aka 'subsecond_duration<boost::posix_time::time_duration, 1000>')
boost::this_thread::sleep(boost::posix_time::milliseconds(1.0));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
host/lib/usrp/x300/x300_impl.cpp:1533:66: error: no matching conversion for functional-style cast from 'double' to 'boost::posix_time::milliseconds' (aka 'subsecond_duration<boost::posix_time::time_duration, 1000>')
boost::system_time timeout_time = boost::get_system_time() + boost::posix_time::milliseconds(timeout * 1000.0);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
host/examples/rx_samples_to_file.cpp:177:64: error: no matching conversion for functional-style cast from 'double' to 'boost::posix_time::seconds'
(boost::get_system_time() > (first_lock_time + boost::posix_time::seconds(setup_time))))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
host/examples/rx_samples_to_file.cpp:191:53: error: no matching conversion for functional-style cast from 'double' to 'boost::posix_time::seconds'
if (boost::get_system_time() > (start + boost::posix_time::seconds(setup_time))){
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
host/examples/tx_samples_from_file.cpp:200:39: error: no matching conversion for functional-style cast from 'double' to 'boost::posix_time::milliseconds' (aka 'subsecond_duration<boost::posix_time::time_duration, 1000>')
boost::this_thread::sleep(boost::posix_time::milliseconds(delay));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/local/include/boost/date_time/time_duration.hpp:270:30: note: candidate constructor (the implicit copy constructor) not viable: no known conversion from 'double' to 'const boost::date_time::subsecond_duration<boost::posix_time::time_duration, 1000>' for 1st argument
class BOOST_SYMBOL_VISIBLE subsecond_duration : public base_duration
^
/usr/local/include/boost/date_time/time_duration.hpp:270:30: note: candidate constructor (the implicit move constructor) not viable: no known conversion from 'double' to 'boost::date_time::subsecond_duration<boost::posix_time::time_duration, 1000>' for 1st argument
/usr/local/include/boost/date_time/time_duration.hpp:286:59: note: candidate template ignored: disabled by 'enable_if' [with T = double]
typename boost::enable_if<boost::is_integral<T>, void>::type* = 0) :
^
|
@jbeich Thanks a lot for submitting this! We're already looking into some of these errors, although our solution is to go straight to C++11 time features. However, we'll probably pull in some of these changes. |
|
I've manually pulled this into our CI system, the changes should go live soon. Note that I had to change the commit as we'd already fixed some changes by moving to |
|
Many thanks again for doing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regressed by boostorg/date_time@f9f2aaf5216c. Found downstream (error log).
UHD < 3.11 (e.g.,
release_003_010_003_000tag) also need 305d0e7:uhd/host/examples/benchmark_rate.cpp
Line 34 in ef15767
uhd/host/examples/benchmark_rate.cpp
Line 474 in ef15767