Add disabled prop to ButtonLink #1008
Conversation
Preview available
|
There was a problem hiding this comment.
Thanks @egeakman! I was a bit scared when the email notification says 14 files changed for the ButtonLink PR. But now I see you've done a much bigger job! <3
Questions not in diff:
- The only place we still use the buttons are in the voting.mdx page. I am not sure if it makes sense to keep the component just for that.
- could we delete the card-container.tsx file now?
A small comment: I think I need to speed up the _test.mdx now so people don't get frustrated when href no longer works in ButtonLink :D
It is a basically a different looking button-ish component which is not really my favorite. I think it was also used in the finaid page.
I was tempted to convert some more components but thought maybe those would be more appropriate for separate PRs. We can remove it and do the card placement logic in the index, or keep it and convert it to Astro. |
Agreed. I would like to dump it too. And since this is the PR related to buttons, maybe we can address it here? I don't see any use of this button component from finaid. Seeing that the styling in the voting app drifted a lot now from the current site, I think it is pointless to keep this button here. Instead we can just use bullet points here in the voting page?
You are right! Let's address the card in another PR! This can be resolved too: #1008 (comment) |
hypha
left a comment
hypha
left a comment
There was a problem hiding this comment.
Thank you for addressing all the comments, Ege! My brain wouldn’t have gone to such a nice and simple solution like using a screenshot for the vote options. <3
- [x] changed the main sponsor page with 2025 content - [x] packages styling and responsive - [x] Highlight stats component - [x] packages tables final pass - [x] packages pdf link undefined - [x] early bird undefined - [x] add-ons needs review - [x] commented out OSS is it is probably not going to be included on this page - [x] converted the sponsor-tiers to astro component (and added a ribbon one to separate out the svg). Not sure if it is a good idea. - [x] fixed ribbon styling overlapping with text - [x] merge #1008 into this due to syntax change for buttons. - [x] add to menu - [x] update faq (milestone and early bird date undefined) - [x] change sponsor-tiers signup form from undefined to real link - [x] add volume discount (not needed until after ticket launch) - [x] add cta --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Mia Bajić <38294198+clytaemnestra@users.noreply.github.com> Co-authored-by: Ege Akman <me@egeakman.dev>
See https://add-disabled-prop.ep-preview.click/programme/mentorship/ for example
Closes #978