Skip to content

Conversation

@cmaureir
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2025

Preview available

Key Value
url https://close-reviews.ep-preview.click
last update 2025-02-19T13:36:11.555Z

Copy link
Contributor

@hypha hypha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @cmaureir! <3

  1. Could you update the reviewer card too?
  2. For both the voting and the reviewer card, could you comment out the original content instead of deleting them? I hear people find it easier to not have to dig into git history to see what the previous content is.
  3. Could you update the top of the CfP page too? (I know it is delisted from the menu, but might be good to keep the information correct there still?)

Copy link
Member

@egeakman egeakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cmaureir!

Copy link
Contributor

@cybit cybit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason the Prague picture is empty in the preview. Or is that just me?

@hypha
Copy link
Contributor

hypha commented Feb 18, 2025

For some reason the Prague picture is empty in the preview. Or is that just me?

you mean this one? I see it in the preview. It only disappears in small screens (which might be intentional?)

@cybit
Copy link
Contributor

cybit commented Feb 18, 2025

For some reason the Prague picture is empty in the preview. Or is that just me?

you mean this one? I see it in the preview. It only disappears in small screens (which might be intentional?)

Not a small screen but now it resurfaced? So consider the a my system error please. It was just a white rectangle before.

Co-authored-by: Ege Akman <me@egeakman.dev>
@cmaureir
Copy link
Contributor Author

Feel free to take over and apply your suggestions. I have been sick since last night, and this needed to be merged last night :(

Copy link
Contributor

@cybit cybit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did ass a few comments on things. None of them are strictly necessary.

@cybit cybit requested a review from hypha February 19, 2025 12:57
@cybit cybit merged commit f669e61 into ep2025 Feb 19, 2025
4 checks passed
@cybit cybit deleted the close_reviews branch February 19, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants