-
Notifications
You must be signed in to change notification settings - Fork 72
Improve search. #1111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve search. #1111
Conversation
Preview available
|
clytaemnestra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Can we keep the old search bar for bigger screens? |
|
There is a place for suggestions feature. |
|
Search should be inside of modal but we don't have that component implemented yet. |
I think no we don't want have two different components for the same functionality, current one is unified for mobile and desktop, and before we had responsiveness issues. When we will have modal implemented desktop search can be inside modal. |
|
@nikoshell so we have two options:
Do I understand it correctly? |
|
I will improve functionality to looks like this one https://starlight.astro.build/ |
0e92b28 to
896e35a
Compare
896e35a to
9c1a30a
Compare
4437b62 to
e23b5b8
Compare
e23b5b8 to
1bf0884
Compare
|
There are header changes which fix this issue. |
clytaemnestra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks and works great, thanks!
|
Can we make the search pop-up lose focus (close) when clicked outside of it? Also, the search menu closes when I hit search on the phone keyboard. |
egeakman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks and works good!! Thanks!


Close #1052.