Skip to content

Conversation

@nikoshell
Copy link
Contributor

Close #1052.

@nikoshell nikoshell requested a review from clytaemnestra April 4, 2025 19:52
@europython-society
Copy link
Member

europython-society commented Apr 4, 2025

Preview available

Key Value
url https://ep2025-search.ep-preview.click
last update 2025-04-15T15:49:41.154Z

Copy link
Contributor

@clytaemnestra clytaemnestra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't look quite well on the desktop

image

@egeakman
Copy link
Member

egeakman commented Apr 5, 2025

Can we keep the old search bar for bigger screens?

@nikoshell
Copy link
Contributor Author

There is a place for suggestions feature.

@nikoshell
Copy link
Contributor Author

Search should be inside of modal but we don't have that component implemented yet.

@nikoshell
Copy link
Contributor Author

Can we keep the old search bar for bigger screens?

I think no we don't want have two different components for the same functionality, current one is unified for mobile and desktop, and before we had responsiveness issues. When we will have modal implemented desktop search can be inside modal.

@clytaemnestra
Copy link
Contributor

@nikoshell so we have two options:

  1. either have this, the same, component for both mobile and desktop, which doesn't look nice, but works
  2. or have no search on mobile at all

Do I understand it correctly?

@nikoshell
Copy link
Contributor Author

I will improve functionality to looks like this one https://starlight.astro.build/

@nikoshell nikoshell force-pushed the ep2025-search branch 3 times, most recently from 0e92b28 to 896e35a Compare April 11, 2025 19:10
@nikoshell nikoshell force-pushed the ep2025-search branch 2 times, most recently from 4437b62 to e23b5b8 Compare April 11, 2025 22:38
@nikoshell nikoshell requested a review from clytaemnestra April 12, 2025 07:38
@nikoshell
Copy link
Contributor Author

There are header changes which fix this issue.
Close #1120.

Copy link
Contributor

@clytaemnestra clytaemnestra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great, thanks!

@egeakman
Copy link
Member

egeakman commented Apr 13, 2025

The upper part (Search text and close button) looks a bit weird when scrolled down. Maybe we can add some sort of semi-transparent background to the top area (something similar to the ctrl+k text)?

image

@egeakman
Copy link
Member

egeakman commented Apr 14, 2025

Can we make the search pop-up lose focus (close) when clicked outside of it? Also, the search menu closes when I hit search on the phone keyboard.

@nikoshell nikoshell requested a review from clytaemnestra April 15, 2025 09:44
Copy link
Member

@egeakman egeakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works good!! Thanks!

@egeakman egeakman merged commit 553b11a into ep2025 Apr 15, 2025
3 checks passed
@egeakman egeakman deleted the ep2025-search branch April 15, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search on Mobile

5 participants