Update speakers page look. #1159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Preview available
|
egeakman
reviewed
Apr 18, 2025
Member
There was a problem hiding this comment.
I think the featured speakers section is a great idea, thank you @nikoshell ❤️
Can we use our button component instead of a div and a a?
Member
|
Also, would it be easy to make it scrollable with/without |
Contributor
Author
|
Depend on the needs, we want encourage to open "all speakers". |
Member
Sounds good. |
clytaemnestra
requested changes
Apr 20, 2025
Contributor
clytaemnestra
left a comment
clytaemnestra
left a comment
There was a problem hiding this comment.
Actually no, it doesn't look good on mobile - can you fix this please?
nikoshell
force-pushed
the
ep2025-better-speakers
branch
from
d82a347 to
5162ee4
Compare
nikoshell
force-pushed
the
ep2025-better-speakers
branch
from
5162ee4 to
5638729
Compare
clytaemnestra
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.