-
Notifications
You must be signed in to change notification settings - Fork 72
Create dedicated CfP landing page #964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
hypha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Jodie! Some wee comments to a very nice page!
In addition, I wonder if it is helpful to link to /tracks, /selection process, and maybe even /mentorship somewhere so that all CfP related information are referenced here (totally OK if we don't though!)
As for the questions:
- indeed, no change is needed for the links.json.
- I do believe you need to delete the cfp.astro file to remove the redirect: https://github.com/EuroPython/website/blob/ep2025/src/pages/programme/cfp.astro. Then when cfp.mdx exists, it will go there.
- the button syntax is added as a suggestion in place.
Co-authored-by: hypha <ramble.dalloway@gmail.com>
for more information, see https://pre-commit.ci
t-redactyl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accepted all of the changes (thank you for updating the button!) and replied to the comments.
|
I've added the requested changes @hypha - let me know if it looks good to go! |
hypha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cybit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's not the proper, proper form to have spaces before and after an em-dash. But I do prefer the space because it breaks up the words instead of connecting them and I'm not sure if the browsers do line-breaks correctly when there is no space. And if TTS-readers are all able to detect that there are two words.
Co-authored-by: Cyril Bitterich <cebit-github@gunnet.de>
Adding content to make a dedicated landing page for the CfPs with additional information. This page will provide a link for users to go through to the CfP Pretalx page.
Outstanding questions: