New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fitter] Polarized weapons and T3 subsystems #62

Closed
Slivo-fr opened this Issue Aug 4, 2017 · 2 comments

Comments

2 participants
@Slivo-fr
Collaborator

Slivo-fr commented Aug 4, 2017

Original bug report

The way resistance calculation is done result in T3C with resist sub having some resists.
The sub effect should be computed before the polarized effect so it's override

Steps to reproduce

  1. Open a T3C fitting (Legion).
  2. Fit a subsystem that provide a bonus to resistances (ex. Legion Defensive - Augmented Plating).
  3. Make sure the skill related to the step 2 sub is at least 1.
  4. Add a polarized weapon to the fitting.

Bug

The ship still have some resistance provided by the subsystem.

Expected

The polarized weapon remove all resistances from the ship once fitted.

Fixed in

2.31.5

@Slivo-fr Slivo-fr added the bug label Aug 4, 2017

@Eshva

This comment has been minimized.

Show comment
Hide comment
@Eshva

Eshva Aug 5, 2017

Collaborator

@Slivo-fr I don't understand what is "resist sub". Please specify it and write "Steps to reproduce" section with "Bug" and "Expected" sections as well like I done in my issues.

Collaborator

Eshva commented Aug 5, 2017

@Slivo-fr I don't understand what is "resist sub". Please specify it and write "Steps to reproduce" section with "Bug" and "Expected" sections as well like I done in my issues.

@Slivo-fr

This comment has been minimized.

Show comment
Hide comment
@Slivo-fr

Slivo-fr Aug 5, 2017

Collaborator

Steps to reproduce

  1. Open a T3C fitting
  2. Fit a subsystem that provide a bonus to resistances
  3. Make sure the skill related to the step 2 sub is at least 1
  4. Add a prolarized weapon to the fitting

Bug

The ship still have some resistance provided by the subsystem

Expected

The polarized weapon remove all resistances from the ship once fitted

Collaborator

Slivo-fr commented Aug 5, 2017

Steps to reproduce

  1. Open a T3C fitting
  2. Fit a subsystem that provide a bonus to resistances
  3. Make sure the skill related to the step 2 sub is at least 1
  4. Add a prolarized weapon to the fitting

Bug

The ship still have some resistance provided by the subsystem

Expected

The polarized weapon remove all resistances from the ship once fitted

@Eshva Eshva self-assigned this Aug 5, 2017

@Eshva Eshva closed this Aug 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment