New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fitter] Localized Eve Fitting import #63

Closed
Slivo-fr opened this Issue Aug 4, 2017 · 0 comments

Comments

2 participants
@Slivo-fr
Collaborator

Slivo-fr commented Aug 4, 2017

Original bug report

Eve is now adding a localized hint into the XML file. EveHQ does not handle it yet and fail to detect exported fittings.

<?xml version="1.0" ?>
<fittings>
    <fitting name="Moustique_Nonni">
        <description value=""/>
        <shipType value="<localized hint="Talwar">Talwar</localized>"/>
            <hardware slot="rig slot 2" type="<localized hint="Petit accélérateur de chargement de baie I">Small Bay Loading Accelerator I</localized>"/>
            <hardware slot="rig slot 1" type="<localized hint="Petite unité d'overclocking du processeur I">Small Processor Overclocking Unit I</localized>"/>
            <hardware slot="rig slot 0" type="<localized hint="Petit projecteur de champs d'ions I">Small Ionic Field Projector I</localized>"/>
            <hardware slot="hi slot 6" type="<localized hint="Lance-missiles léger compact 'Balliste'">Arbalest Compact Light Missile Launcher</localized>"/>
            <hardware slot="hi slot 5" type="<localized hint="Lance-missiles léger compact 'Balliste'">Arbalest Compact Light Missile Launcher</localized>"/>
            <hardware slot="hi slot 4" type="<localized hint="Lance-missiles léger compact 'Balliste'">Arbalest Compact Light Missile Launcher</localized>"/>
            <hardware slot="hi slot 3" type="<localized hint="Lance-missiles léger compact 'Balliste'">Arbalest Compact Light Missile Launcher</localized>"/>
            <hardware slot="hi slot 2" type="<localized hint="Lance-missiles léger compact 'Balliste'">Arbalest Compact Light Missile Launcher</localized>"/>
            <hardware slot="hi slot 1" type="<localized hint="Lance-missiles léger compact 'Balliste'">Arbalest Compact Light Missile Launcher</localized>"/>
            <hardware slot="hi slot 0" type="<localized hint="Lance-missiles léger compact 'Balliste'">Arbalest Compact Light Missile Launcher</localized>"/>
            <hardware slot="med slot 2" type="<localized hint="Micropropulseur de warp Quad LiF restreint 5MN">5MN Quad LiF Restrained Microwarpdrive</localized>"/>
            <hardware slot="med slot 1" type="<localized hint="Ordinateur de guidage de missiles II">Missile Guidance Computer II</localized>"/>
            <hardware slot="med slot 0" type="<localized hint="Champ d'invulnérabilité adaptatif II">Adaptive Invulnerability Field II</localized>"/>
            <hardware slot="low slot 2" type="<localized hint="Coprocesseur II">Co-Processor II</localized>"/>
            <hardware slot="low slot 1" type="<localized hint="Système de contrôle balistique I">Ballistic Control System I</localized>"/>
            <hardware slot="low slot 0" type="<localized hint="Contrôle des dégâts II">Damage Control II</localized>"/>
            <hardware qty="1290" slot="cargo" type="<localized hint="Missile léger Scourge">Scourge Light Missile</localized>"/>
            <hardware qty="1863" slot="cargo" type="<localized hint="Missile léger Inferno">Inferno Light Missile</localized>"/>
            <hardware qty="749" slot="cargo" type="<localized hint="Missile léger Mjolnir">Mjolnir Light Missile</localized>"/>
            <hardware qty="2158" slot="cargo" type="<localized hint="Missile léger Nova">Nova Light Missile</localized>"/>
            <hardware qty="230" slot="cargo" type="<localized hint="Missile léger Mjolnir à ciblage automatique I">Mjolnir Auto-Targeting Light Missile I</localized>"/>
            <hardware qty="1000" slot="cargo" type="<localized hint="Missile léger Scourge à ciblage automatique I">Scourge Auto-Targeting Light Missile I</localized>"/>
            <hardware qty="1062" slot="cargo" type="<localized hint="Missile léger Nova à ciblage automatique I">Nova Auto-Targeting Light Missile I</localized>"/>
            <hardware qty="1100" slot="cargo" type="<localized hint="Missile léger Inferno à ciblage automatique I">Inferno Auto-Targeting Light Missile I</localized>"/>
            <hardware qty="1" slot="cargo" type="<localized hint="Script de portée du système de ciblage">Targeting Range Script</localized>"/>
            <hardware qty="1" slot="cargo" type="<localized hint="Script de CCME">ECCM Script</localized>"/>
    </fitting>
</fittings>

Steps to reproduce

  1. Save in the folder %USERPROFILE%\Documents\EVE\fittings XML from original bug report as talwar.xml
  2. Open the Fitter. Click Import Eve Fittings button.

Bug

The Talwar fitting isn't present in the tree of loaded EVE fittings.

Expected

The Talwar fitting present in the tree and can be imported.

Developer notes

Probably the XML file is has bad syntax. XML cannot contain characters <> because it is reserved characters of XML. Shame on CCP!!!

Fixed in

2.31.5

@Slivo-fr Slivo-fr added the bug label Aug 4, 2017

@Eshva Eshva self-assigned this Aug 5, 2017

@Eshva Eshva closed this Aug 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment