New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prism] Exception for some structures #80

Closed
Eshva opened this Issue Aug 22, 2017 · 0 comments

Comments

1 participant
@Eshva
Collaborator

Eshva commented Aug 22, 2017

Description

Some structures have bad data in Citadel API. On starting Prism an exception occurs:

*****START Aggregate Exception Details*****
Message: One or more errors occurred.
Source: mscorlib
StackTrace: at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
at EveHQ.Prism.Classes.Locations.GetStructureLocation(Int64 locationId) in B:\Projects\GitHub\EveHQ-Team\EveHQ\EveHQ.Prism\Classes\Locations.vb:line 129
at EveHQ.Prism.Classes.Locations.GetLocationFromID(Int64 locationId) in B:\Projects\GitHub\EveHQ-Team\EveHQ\EveHQ.Prism\Classes\Locations.vb:line 53
at EveHQ.Prism.Controls.PrismAssetsControl.PopulateAssetTree() in B:\Projects\GitHub\EveHQ-Team\EveHQ\EveHQ.Prism\Controls\PrismAssetsControl.vb:line 645
at EveHQ.Prism.Controls.PrismAssetsControl.PopulateAssets() in B:\Projects\GitHub\EveHQ-Team\EveHQ\EveHQ.Prism\Controls\PrismAssetsControl.vb:line 398
at EveHQ.Prism.Controls.PrismAssetsControl.RefreshAssets() in B:\Projects\GitHub\EveHQ-Team\EveHQ\EveHQ.Prism\Controls\PrismAssetsControl.vb:line 139
at EveHQ.Prism.Controls.PrismAssetsControl.btnRefreshAssets_Click(Object sender, EventArgs e) in B:\Projects\GitHub\EveHQ-Team\EveHQ\EveHQ.Prism\Controls\PrismAssetsControl.vb:line 130
at System.Windows.Forms.Control.OnClick(EventArgs e)
at DevComponents.DotNetBar.ButtonX.OnClick(EventArgs e)
at DevComponents.DotNetBar.ButtonX.OnMouseUp(MouseEventArgs e)
at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
at System.Windows.Forms.Control.WndProc(Message& m)
at DevComponents.DotNetBar.PopupItemControl.WndProc(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
*****Inner Exceptions*****
*****START Exception Details*****
Message: Null object cannot be converted to a value type.
Source: mscorlib
StackTrace: at System.Convert.ChangeType(Object value, Type conversionType, IFormatProvider provider)
at Newtonsoft.Json.Linq.Extensions.Convert[T,U](T token)
at Newtonsoft.Json.Linq.Extensions.Value[T,U](IEnumerable`1 value)
at EveHQ.NewEveApi.StructureNameClient.GetStructureDataFromJson(String response, HttpStatusCode responseStatusCode, DateTimeOffset cacheTime) in B:\Projects\GitHub\EveHQ-Team\EveHQ\EveHQ.NewEveAPI\StructureNameClient.cs:line 79
at EveHQ.NewEveApi.StructureNameClient.ProcessServiceResponse(Task`1 webTask, String cacheKey, Int32 defaultCacheSeconds) in B:\Projects\GitHub\EveHQ-Team\EveHQ\EveHQ.NewEveAPI\StructureNameClient.cs:line 67
at EveHQ.NewEveApi.StructureNameClient.c__DisplayClass1_0.b__0(Task`1 webTask) in B:\Projects\GitHub\EveHQ-Team\EveHQ\EveHQ.NewEveAPI\StructureNameClient.cs:line 45
at System.Threading.Tasks.ContinuationResultTaskFromResultTask`2.InnerInvoke()
at System.Threading.Tasks.Task.Execute()
*****END Exception Details*****
*****END Aggregate Exception Details*****

========== Plug-ins ==========

EveHQ.HQF.dll (1.0.0.0)
EveHQ.KillMailViewer.dll (1.0.0.0)
EveHQ.Prism.dll (1.0.0.0)
EveHQ.Void.dll (1.0.0.0)

========= System Info ========= 

For instance the structure P3EN-E - Trump Tower has bad data:
{"1023192414683": {"typeId": null, "regionId": 10000003, "typeName": null, "lastSeen": "2017-06-10T15:06:17.300Z", "firstSeen": "2017-01-26T23:49:18Z", "regionName": "Vale of the Silent", "name": "P3EN-E - Trump Tower", "systemId": 30000250, "location": null, "systemName": "P3EN-E", "public": false}}

Bug

Exception

Expected

No exceptions on starting Prism. Bad structure data should have some meaningful values.

Fixed in

2.31.7

@Eshva Eshva self-assigned this Aug 22, 2017

@Eshva Eshva added the bug label Aug 22, 2017

Eshva pushed a commit that referenced this issue Aug 22, 2017

@Eshva Eshva closed this Aug 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment