Add dispatchEvent to EventSource #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afroozeh
force-pushed
the
add-eventdispatch-to-eventsource
branch
from
fd80b3d
to
f78f08f
Compare
|
This looks good to me, any objections, @piranna or @aslakhellesoy ? |
rexxars
approved these changes
Aug 24, 2018
piranna
approved these changes
Aug 24, 2018
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Adds
dispatchEventmethod to EventSource to make it compatible with theEventSourcedefinition form https://developer.mozilla.org/en-US/docs/Web/API/EventSource.EventSourceextendsEventTargetthat has thedispatchEventmethod:https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/dispatchEvent
The
EventandCustomEventobjects are only available in DOM, so I tried to simulate them by{ type: string}and{type: string, detail: object}object literals:https://developer.mozilla.org/en-US/docs/Web/Guide/Events/Creating_and_triggering_events