Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eventsource 50x support #74

Merged
merged 2 commits into from May 10, 2017
Merged

Conversation

@ScalaWilliam
Copy link
Contributor

@ScalaWilliam ScalaWilliam commented May 10, 2017

Based on the processing model,

image

In Google Chrome this is implemented correctly:

  1. EventSource instance connects to the server.
  2. Server breaks the connection.
  3. Because it's a back-end behind nginx, now it returns a 502 error code.
  4. After some time, the HTTP service returns to normal and begins serving content (and 200 status codes) again.
  5. EventSource instance continues receiving messages.
@rexxars
Copy link
Member

@rexxars rexxars commented May 10, 2017

Thanks, this looks great!

@rexxars rexxars merged commit 91437de into EventSource:master May 10, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rexxars
Copy link
Member

@rexxars rexxars commented May 10, 2017

Published as v1.0.1

@ScalaWilliam
Copy link
Contributor Author

@ScalaWilliam ScalaWilliam commented May 10, 2017

Thank you @rexxars, that was very fast. It now works as expected in my project.

ScalaWilliam added a commit to ActionFPS/actionfps-clone-logs that referenced this pull request May 10, 2017
Document it,
Use what I did for EventSource 1.0.1, EventSource/eventsource#74
Use new name,
Publish :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants