Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make close() a prototype method. Closes #67. #77

merged 1 commit into from May 28, 2017


Copy link

@rexxars rexxars commented May 17, 2017

This PR moves the close() method to the EventSource prototype, in order to align with the browser implementation and allow overriding it when subclassing.

Copy link

@joeybaker joeybaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what it's worth, this looks good to me.

@rexxars rexxars merged commit 0c9eae0 into EventSource:master May 28, 2017
@rexxars rexxars deleted the close-on-prototype branch May 28, 2017 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants