Pass withCredentials on to the XHR #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- See https://www.w3.org/TR/eventsource/#dom-eventsource-withcredentials - I noticed during application testing that `{withCredentials: true}` was not including the session cookie, in fact, setting the flag in the polyfill had no effect at all. After a little digging, I learned that simply passing the option to the `http` object was that was needed. - I tried writing a test to confirm this, but could not figure out a way to do it (the only difference in real life is that the `Cookie` header is set if there's a cookie in the `document`
|
Thanks! |
|
Published as v1.0.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
{withCredentials: true}wasnot including the session cookie, in fact, setting the flag in the polyfill
had no effect at all. After a little digging, I learned that simply passing
the option to the
httpobject was all that was needed.do it (the only difference in real life is that the
Cookieheader is setif there's a cookie in the
document