metadata_content_type required, while metadata is optional #58

Closed
t3hnar opened this Issue Jul 20, 2013 · 2 comments

Comments

Projects
None yet
2 participants
@t3hnar
Member

t3hnar commented Jul 20, 2013

Hi guys
in ClientMessageDtos.proto (NewEvent/EventRecord).metadata_content_type is required
However metadata is optional

Looks like a bug.

@gregoryyoung

This comment has been minimized.

Show comment
Hide comment
@gregoryyoung

gregoryyoung Jul 20, 2013

Member

the metadata_content_type is not used at this time (its there for when the feature gets added to not break protos) and there will be a value for "unknown" 0 which happens to be the default :)

Member

gregoryyoung commented Jul 20, 2013

the metadata_content_type is not used at this time (its there for when the feature gets added to not break protos) and there will be a value for "unknown" 0 which happens to be the default :)

@t3hnar

This comment has been minimized.

Show comment
Hide comment
@t3hnar

t3hnar Jul 20, 2013

Member

still, better not pass one more odd int32 over the network, let's define that with default on layer above at client/server side

Member

t3hnar commented Jul 20, 2013

still, better not pass one more odd int32 over the network, let's define that with default on layer above at client/server side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment