New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle all messages in queue #1279

Merged
merged 1 commit into from Apr 18, 2017

Conversation

3 participants
@pgermishuys
Member

pgermishuys commented Apr 18, 2017

There are cases when the consumer can throw and in those cases the proceeeding messages in the batch are not handled

Handle all messages in queue
There are cases when the consumer can throw and in those cases the
proceeeding messages in the batch are not handled
@hayley-jean

Tested this using a db that contained a projection that would fault when loaded up on newer versions (the $users projection from an earlier version). This projection was then stopped to force its definition to be written, which excluded the source definition.

On 3.9.3, the projection would get stuck in the Loaded state, and the other projections would be loaded and start processing as normal.

On 4.0.0, the projection would still get stuck in the Loaded state and if the queue was held up or slow, the other projections would not load properly.

This no longer happens with this change.

@hayley-jean hayley-jean merged commit 6c94358 into release-v4.0.1 Apr 18, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
wercker/build-mono4 Wercker pipeline passed
Details

@hayley-jean hayley-jean deleted the handle_all_messages branch Apr 18, 2017

@gregoryyoung

This comment has been minimized.

Show comment
Hide comment
@gregoryyoung
Member

gregoryyoung commented Apr 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment