Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Revert to legacy queued handler. #1280
ready for merge
Apr 20, 2017
Apr 21, 2017
added a commit
this pull request
Apr 21, 2017
likely will. There is not a dramatic performance increase. My bigger worry is there is a bug in other environments possibly including windows and we have not run into it yet. Risk management would suggest, revert it out for all platforms, further testing over a week or two then review.
@Scooletz not mono only. AWS linux only. We have not seen the issue in ubuntu etc. It may exist in OSX as well (have not tested enough)
@Scooletz I can also send over threadstacks (managed + gdbg) showing the problem. Basically processing locks (in this case on rebuilding an index). CPU pegs up threadstacks keep coming back withenqueue on the top. It being there is a while(true) it seems like a reasonable candidate for an access pattern problem that loops forever. We have a reproduction now, a reasonable test would be to try limit that to some large number (say 50k) and see if the issue still occurs.
a perflog shows the enqueue methods using CPU.
Here is a thread stack: