New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes checkpoint bug #1302

Merged
merged 2 commits into from May 23, 2017

Conversation

3 participants
@shaan1337
Member

shaan1337 commented May 12, 2017

Fixes #1301
Wrong sentinel value was being used as described in issue.

From what I understood, correct behaviour is:
If there's at least one message in either _streamBuffer or _outstandingMessages:
"lowest" will contain the smallest event number among all messages
Otherwise:
"lowest" will contain the event number of "_lastKnownMessage"

@pgermishuys

This comment has been minimized.

Show comment
Hide comment
@pgermishuys

pgermishuys May 12, 2017

Member

You are on a roll! Thanks for another PR @shaan1337!
I didn't see any test changes... this will need some reviewing.

Member

pgermishuys commented May 12, 2017

You are on a roll! Thanks for another PR @shaan1337!
I didn't see any test changes... this will need some reviewing.

@shaan1337

This comment has been minimized.

Show comment
Hide comment
@shaan1337

shaan1337 May 13, 2017

Member

You're welcome :) Thanks for the feedback, I'll try to add in a test.

Member

shaan1337 commented May 13, 2017

You're welcome :) Thanks for the feedback, I'll try to add in a test.

@hayley-jean

This comment has been minimized.

Show comment
Hide comment
@hayley-jean

hayley-jean May 23, 2017

Contributor

Looks good @shaan1337

Contributor

hayley-jean commented May 23, 2017

Looks good @shaan1337

@hayley-jean hayley-jean merged commit af2e705 into EventStore:release-v4.0.2 May 23, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
wercker/build-mono4 Wercker pipeline passed
Details

hayley-jean added a commit that referenced this pull request Jul 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment