New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Windows specific projection dev. env. #1314

Merged
merged 1 commit into from May 25, 2017

Conversation

2 participants
@pgermishuys
Member

pgermishuys commented May 25, 2017

Fixes #1232
Fixes #1198
Potentially Fixes some of the issues raised in #1032

  • Remove the non-existent projects and pull in ClusterNode into the

  • Windows specific development solution for Projections.

  • Increase projection compile time timeout to 5 seconds from 1 second

  • Scope the HandleScope

The HandleScope attempts to track all the local handles allocated within
the handle scope until the handle scope is deleted. In this, we are
deleting resources that it is tracking and once it goes out of scope
it's trying to clean up it's resources which in this case might refer to
the isolate that was already disposed as part of deleting the prelude
script.

Cleanup Windows specific projection dev. env.
Remove the non-existent projects and pull in ClusterNode into the
Windows specific development solution for Projections.

Increase projection compile time timeout to 5 seconds

Scope the HandleScope

The HandleScope attempts to track all the local handles allocated within
the handle scope until the handle scope is deleted. In this, we are
deleting resources that it is tracking and once it goes out of scope
it's trying to clean up it's resources which in this case might refer to
the isolate that was already disposed as part of deleting the prelude
script.

@hayley-jean hayley-jean merged commit e53d1e2 into release-v4.0.2 May 25, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
wercker/build-mono4 Wercker pipeline passed
Details

@hayley-jean hayley-jean deleted the handle-projection-compile-timeout branch May 25, 2017

hayley-jean added a commit that referenced this pull request Jul 31, 2017

Merge pull request #1314 from EventStore/handle-projection-compile-ti…
…meout

Cleanup Windows specific projection dev. env.

pgermishuys added a commit that referenced this pull request Aug 4, 2017

Merge pull request #1314 from EventStore/handle-projection-compile-ti…
…meout

Cleanup Windows specific projection dev. env.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment