Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkpoint after a certain period #1338

Merged
merged 1 commit into from Jun 13, 2017
Merged

Conversation

@pgermishuys
Copy link
Contributor

pgermishuys commented Jun 13, 2017

We don't want to be checkpointing too often in a busy projection. There
is a lot of overhead associated with creating a checkpoint and creating
the associated emitted streams.

This commit adds a checkpoint after configuration value for projections
which will only checkpoint after x number of events and only once the
checkpoint after period has elapsed

Todo:
Convert all the constants to actual constants.

We don't want to be checkpointing too often in a busy projection. There
is a lot of overhead associated with creating a checkpoint and creating
the associated emitted streams.

This commit adds a checkpoint after configuration value for projections
which will only checkpoint after x number of events and only once the
checkpoint after period has elapsed
Copy link
Contributor

hayley-jean left a comment

I have confirmed that the checkpoints on a busy system are delayed when they arrive in a short timeframe rather than being written immediately.

@hayley-jean hayley-jean merged commit 6ec4a78 into release-v4.0.2 Jun 13, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
wercker/build-mono4 Wercker pipeline passed
Details
@hayley-jean hayley-jean deleted the projection-checkpoint branch Jun 13, 2017
hayley-jean added a commit that referenced this pull request Jul 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.