New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time out reads in the ProjectionManagerResponseReader #1346

Merged
merged 1 commit into from Jul 4, 2017

Conversation

4 participants
@hayley-jean
Contributor

hayley-jean commented Jul 3, 2017

Fixes #1330

Implement the $projections-$master read loop using a series of messages rather than using a while loop.
Add a read timeout that will kick off a new read to prevent the response reader from stalling.

Time out reads in the ProjectionManagerResponseReader
Implement the $projections-$master read loop using a series of messages rather than using a while loop.
Add a read timeout that will kick off a new read to prevent the response reader from stalling.
Retry reads that fail infinitely.
@trustedsec

This comment has been minimized.

Show comment
Hide comment
@trustedsec

trustedsec commented Jul 3, 2017

Thank you @hayley-jean !

@pgermishuys pgermishuys merged commit 0d52a99 into release-v4.0.2 Jul 4, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
wercker/build-mono4 Wercker pipeline passed
Details

@pgermishuys pgermishuys deleted the projection-manager-reader-timeout branch Jul 4, 2017

@shouze

This comment has been minimized.

Show comment
Hide comment
@shouze

shouze Jul 5, 2017

Great one, we also had this message about very slow queues sometime

shouze commented Jul 5, 2017

Great one, we also had this message about very slow queues sometime

hayley-jean added a commit that referenced this pull request Jul 31, 2017

Merge pull request #1346 from EventStore/projection-manager-reader-ti…
…meout

Time out reads in the ProjectionManagerResponseReader
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment