New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of the idempotency checks when attempting rewrites #1356

Merged
merged 1 commit into from Jul 13, 2017

Conversation

2 participants
@pgermishuys
Member

pgermishuys commented Jul 12, 2017

No description provided.

@hayley-jean

Tested this by forcing a commit timeout when writing the registration event one of the system projections.

When this happens on 4.0.2, the registration event is written again to $projections-$all, resulting in two registration events for the same projection. The projection will then run and process events, but on a restart of Event Store projections throw errors such as "An item with the same key has already been added" and the projections do not come up.

This is no longer reproducible on this branch as the retried event results in an idempotent write.

@hayley-jean hayley-jean merged commit f98a9ed into release-v4.0.2 Jul 13, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
wercker/build-mono4 Wercker pipeline passed
Details

@hayley-jean hayley-jean deleted the retry_projection_registration_with_same_id branch Jul 13, 2017

hayley-jean added a commit that referenced this pull request Jul 31, 2017

Merge pull request #1356 from EventStore/retry_projection_registratio…
…n_with_same_id

Make use of the idempotency checks when attempting rewrites
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment