New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry the projections initialized write idempotently #1360

Merged
merged 1 commit into from Jul 14, 2017

Conversation

2 participants
@pgermishuys
Member

pgermishuys commented Jul 13, 2017

The accompanying test for the change is not infinitely retrying
because the write is being retried indefinitely.

Retry the projections initialized write idempotently
The accompanying test for the change is not infinitely retrying
because the write is being retried indefinitely.
@hayley-jean

hayley-jean approved these changes Jul 14, 2017 edited

Forcing a commit timeout despite successfully writing an event when writing a projections initialized event on 4.0.2 causes the projections to simply not load at all. This is due to the event being written with the expected version of no stream.

With this change, the write is retried and results in an idempotent write. Projections then continue loading happily.

@hayley-jean hayley-jean merged commit e520b61 into release-v4.0.2 Jul 14, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
wercker/build-mono4 Wercker pipeline passed
Details

@hayley-jean hayley-jean deleted the retry_projections_initialized_idempotently branch Jul 14, 2017

hayley-jean added a commit that referenced this pull request Jul 31, 2017

Merge pull request #1360 from EventStore/retry_projections_initialize…
…d_idempotently

Retry the projections initialized write idempotently
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment