Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry the projections initialized write idempotently #1360

Merged

Conversation

@pgermishuys
Copy link
Contributor

pgermishuys commented Jul 13, 2017

The accompanying test for the change is not infinitely retrying
because the write is being retried indefinitely.

The accompanying test for the change is not infinitely retrying
because the write is being retried indefinitely.
@pgermishuys pgermishuys force-pushed the retry_projections_initialized_idempotently branch from 22c3d80 to 3cffce9 Jul 13, 2017
Copy link
Contributor

hayley-jean left a comment

Forcing a commit timeout despite successfully writing an event when writing a projections initialized event on 4.0.2 causes the projections to simply not load at all. This is due to the event being written with the expected version of no stream.

With this change, the write is retried and results in an idempotent write. Projections then continue loading happily.

@hayley-jean hayley-jean merged commit e520b61 into release-v4.0.2 Jul 14, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
wercker/build-mono4 Wercker pipeline passed
Details
@hayley-jean hayley-jean deleted the retry_projections_initialized_idempotently branch Jul 14, 2017
hayley-jean added a commit that referenced this pull request Jul 31, 2017
…d_idempotently

Retry the projections initialized write idempotently
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.