New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert timeout of 0 to no timeout when loading config on startup. #1471

Merged
merged 1 commit into from Oct 20, 2017

Conversation

2 participants
@hayley-jean
Contributor

hayley-jean commented Oct 20, 2017

A timeout of 0 milliseconds is used to indicate that messages on the subscription should not time out, and was converted to TimeSpan.MaxValue when it was set.

However, this same conversion did not happen when loading the config for the subscription.
This means that if a subscription with DoNotTimeout() is restarted, messages would timeout immediately after being sent.

Also removed unused block of code for loading config.

@shaan1337 shaan1337 merged commit 53e6ca7 into release-v4.0.4 Oct 20, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
wercker/build-mono4 Wercker pipeline passed
Details

hayley-jean added a commit that referenced this pull request Oct 20, 2017

Merge pull request #1471 from EventStore/persistent-subscription-config
Convert timeout of 0 to no timeout when loading config on startup.

hayley-jean added a commit that referenced this pull request Dec 4, 2017

Merge pull request #1471 from EventStore/persistent-subscription-config
Convert timeout of 0 to no timeout when loading config on startup.

@hayley-jean hayley-jean deleted the persistent-subscription-config branch Dec 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment