New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for scavenged files remaining at 256MB #1520

Merged
merged 1 commit into from Dec 18, 2017

Conversation

2 participants
@shaan1337
Member

shaan1337 commented Dec 14, 2017

Resize the stream before writing the chunk footer
Compare old chunk file sizes instead of calculating them to ensure padding/alignment is also included
Update scavenge tfchunk test to ensure scavenged chunk is smaller than original

Resize the stream before writing the chunk footer
Compare old chunk file sizes instead of calculating them to ensure padding/alignment is also included
Update scavenge tfchunk test to ensure scavenged chunk is smaller than original

@hayley-jean hayley-jean merged commit cd546a3 into release-v4.0.4 Dec 18, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
wercker/build-mono4 Wercker pipeline passed
Details

@hayley-jean hayley-jean deleted the scavenge-chunk-size branch Dec 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment